-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Documentation for the feature https://github.com/kubernetes/kubernetes/issue… #20906
Update Documentation for the feature https://github.com/kubernetes/kubernetes/issue… #20906
Conversation
Hi Team, I'm updating the document for the feature kubernetes/kubernetes#63959
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @smrutiranjantripathy! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Deploy preview for kubernetes-io-master-staging ready! Built with commit e035639 https://deploy-preview-20906--kubernetes-io-master-staging.netlify.app |
/check-cla |
I signed it |
@smrutiranjantripathy is this documented anywhere on AWS? I would think an external link would be a better solution given the SIG Docs 3rd party content KEP/ issue. |
+1 - I agree with @jimangel |
Its not documented on AWS docs. It was a lot of trouble in finding the PR, so I thought of putting in the kubernete main document. |
@smrutiranjantripathy I strongly recommend that you update either https://github.com/kubernetes/cloud-provider-aws/tree/master/docs/book or https://github.com/awsdocs/amazon-eks-user-guide/blob/master/doc_source/load-balancing.md - or attempt that - and then if that lands you change the Kubernetes documentation to hyperlink there. If neither of those places accepts the change you want then in terms of updating the Kubernetes website your options are limited: the policy on documenting third party details is to hyperlink rather than to put that documentation into the website itself. What we can do from a SIG perspective is add some weight to your request to document this change elsewhere. |
@smrutiranjantripathy just to keep things clear, I'm going to close this, but we really do want your contribution! So if you have a chance to address the comments and reopen this PR I'd be happy to help you get this merged! /close |
@zparnold: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi Team,
I'm updating the document for the feature Support Elastic Ips in NLB.
kubernetes/kubernetes#63959