Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Documentation for the feature https://github.com/kubernetes/kubernetes/issue… #20906

Closed

Conversation

smrutiranjantripathy
Copy link

Hi Team,
I'm updating the document for the feature Support Elastic Ips in NLB.
kubernetes/kubernetes#63959

Hi Team, 
I'm updating the document for the feature  kubernetes/kubernetes#63959
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @smrutiranjantripathy!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 12, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign kbhawkey
You can assign the PR to them by writing /assign @kbhawkey in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label May 12, 2020
@netlify
Copy link

netlify bot commented May 12, 2020

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e035639

https://deploy-preview-20906--kubernetes-io-master-staging.netlify.app

@RA489
Copy link

RA489 commented May 13, 2020

/check-cla

@smrutiranjantripathy
Copy link
Author

I signed it

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 20, 2020
@jimangel
Copy link
Member

@smrutiranjantripathy is this documented anywhere on AWS? I would think an external link would be a better solution given the SIG Docs 3rd party content KEP/ issue.

@onlydole
Copy link
Member

+1 - I agree with @jimangel

@smrutiranjantripathy
Copy link
Author

@smrutiranjantripathy is this documented anywhere on AWS? I would think an external link would be a better solution given the SIG Docs 3rd party content KEP/ issue.

Its not documented on AWS docs. It was a lot of trouble in finding the PR, so I thought of putting in the kubernete main document.

@sftim
Copy link
Contributor

sftim commented Jun 21, 2020

@smrutiranjantripathy I strongly recommend that you update either https://github.com/kubernetes/cloud-provider-aws/tree/master/docs/book or https://github.com/awsdocs/amazon-eks-user-guide/blob/master/doc_source/load-balancing.md - or attempt that - and then if that lands you change the Kubernetes documentation to hyperlink there.

If neither of those places accepts the change you want then in terms of updating the Kubernetes website your options are limited: the policy on documenting third party details is to hyperlink rather than to put that documentation into the website itself. What we can do from a SIG perspective is add some weight to your request to document this change elsewhere.

@zparnold
Copy link
Member

zparnold commented Jul 1, 2020

@smrutiranjantripathy just to keep things clear, I'm going to close this, but we really do want your contribution! So if you have a chance to address the comments and reopen this PR I'd be happy to help you get this merged!

/close

@k8s-ci-robot
Copy link
Contributor

@zparnold: Closed this PR.

In response to this:

@smrutiranjantripathy just to keep things clear, I'm going to close this, but we really do want your contribution! So if you have a chance to address the comments and reopen this PR I'd be happy to help you get this merged!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants