Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows HostProcess Container Documentation #28413

Merged
merged 12 commits into from
Jul 27, 2021
Merged

Windows HostProcess Container Documentation #28413

merged 12 commits into from
Jul 27, 2021

Conversation

brasmith-ms
Copy link
Contributor

Documentation pertaining to support for Windows HostProcess containers.

Enhancement: kubernetes/enhancements#1981
PR: kubernetes/kubernetes#99576

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jun 15, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 15, 2021
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented Jun 15, 2021 •
edited by netlify bot
Loading

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 4a0c02e

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60ff4ccbf9f60700073742c7

@k8s-ci-robot
Copy link
Contributor

Welcome @brasmith-ms!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 15, 2021
@brasmith-ms brasmith-ms mentioned this pull request Jun 15, 2021
Closed
35 tasks
@sftim
Copy link
Contributor

sftim commented Jun 15, 2021

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jun 15, 2021
@brasmith-ms brasmith-ms changed the title Added feature gate entry + placeholder commit. Windows HostProcess Container Documentation Jun 15, 2021
@PI-Victor
Copy link
Member

/assign @ashnehete

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 2, 2021
@brasmith-ms
Copy link
Contributor Author

Since we are adding a new HostProcess PSP the documentation here depends on #28903

sftim
sftim reviewed Jul 16, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Here's some more early feedback.

content/en/docs/tasks/configure-pod-container/create-hostprocess-container.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-container.md Outdated Show resolved Hide resolved
@ashnehete
Copy link

Hello @marosset and @brasmith-ms 👋 please take a look at Documenting for a release - PR Ready for Review to get your PR ready for review before Tuesday 20th of July, 11:59 PM PDT. Thank you!

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 16, 2021
@sejr sejr mentioned this pull request Jul 19, 2021
Merged
21 tasks
@brasmith-ms brasmith-ms marked this pull request as ready for review July 19, 2021 23:49
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 19, 2021
brasmith-ms and others added 3 commits July 23, 2021 11:19
@brasmith-ms @liggitt @marosset
Apply suggestions from code review
21af0d5 
Co-authored-by: Jordan Liggitt <jordan@liggitt.net>
Co-authored-by: Mark Rossetti <marosset@microsoft.com>
@brasmith-ms
Merge branch 'dev-1.22' of https://github.com/kubernetes/website into…
b098cef 
… dev-1.22
@brasmith-ms
Moved HostProcess security documentation into PSS and create-host-pro…
fe963d1 
…cess-pod docs
jsturtevant
jsturtevant reviewed Jul 23, 2021
View reviewed changes
content/en/docs/concepts/security/pod-security-standards.md Outdated Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-standards.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Jul 24, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial feedback - I'm adding this now so GitHub doesn't lose it.

content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
sftim
sftim reviewed Jul 24, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More feedback. I hope it's clear - I'll be happy to clarify anything that isn't.

content/en/docs/concepts/security/pod-security-standards.md Show resolved Hide resolved
content/en/docs/concepts/security/pod-security-standards.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/tasks/configure-pod-container/create-hostprocess-pod.md Outdated Show resolved Hide resolved
content/en/docs/concepts/workloads/pods/_index.md Outdated Show resolved Hide resolved
brasmith-ms and others added 2 commits July 23, 2021 17:43
@brasmith-ms @sftim @jsturtevant
Apply suggestions from code review
9360d1a 
Co-authored-by: Tim Bannister <tim@scalefactory.com>
Co-authored-by: James Sturtevant <jsturtevant@gmail.com>
@brasmith-ms
Minor edits
48a3bf0
@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2021

Glad to see all feedbacks addressed.
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@tengqm
Copy link
Contributor

tengqm commented Jul 27, 2021

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jul 27, 2021
@PI-Victor
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d3837d86fe60bcaeca9315f2ed3f6c2c1600613a

@k8s-ci-robot k8s-ci-robot merged commit af2f72a into kubernetes:dev-1.22 Jul 27, 2021
@dcantah dcantah mentioned this pull request Sep 27, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcantah dcantah dcantah left review comments

@tallclair tallclair tallclair left review comments

@sftim sftim sftim left review comments

@jsturtevant jsturtevant jsturtevant requested changes

@bradtopol bradtopol Awaiting requested review from bradtopol

@jimangel jimangel Awaiting requested review from jimangel

@tengqm tengqm Awaiting requested review from tengqm

@liggitt liggitt Awaiting requested review from liggitt

@marosset marosset Awaiting requested review from marosset

Assignees

@PI-Victor PI-Victor

@ashnehete ashnehete

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.