-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Netris and description #29021
Added Netris and description #29021
Conversation
Added description of Netris integration with k8s and included links to solution overview and k8s chart (github).
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✔️ Deploy Preview for kubernetes-io-main-staging ready! 🔨 Explore the source changes: d45d610 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/611a78e480ec2c00078646a5 😎 Browse the preview: https://deploy-preview-29021--kubernetes-io-main-staging.netlify.app |
Reviewers / approvers: please verify that this content is allowed by the content guide. |
Update Netris description
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
("I signed it") |
@@ -275,6 +275,16 @@ Multus supports all [reference plugins](https://github.com/containernetworking/p | |||
|
|||
[OVN4NFV-K8S-Plugin](https://github.com/opnfv/ovn4nfv-k8s-plugin) is OVN based CNI controller plugin to provide cloud native based Service function chaining(SFC), Multiple OVN overlay networking, dynamic subnet creation, dynamic creation of virtual networks, VLAN Provider network, Direct provider network and pluggable with other Multi-network plugins, ideal for edge based cloud native workloads in Multi-cluster networking | |||
|
|||
### Netris | |||
|
|||
The [Netris software controller](https://www.netris.ai/kubernetes/) allows NetOps/DevOps engineers to design and operate a physical network with IaC (Infrastructure as Code), a simple web interface, or by using a modern REST API. Netris has native integration for Kubernetes with which provides automatic creation of network services using CRD based objects: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't use words like "simple", "modern" ...
"native integration", "with which" ... are confusing too.
|
||
The [Netris software controller](https://www.netris.ai/kubernetes/) allows NetOps/DevOps engineers to design and operate a physical network with IaC (Infrastructure as Code), a simple web interface, or by using a modern REST API. Netris has native integration for Kubernetes with which provides automatic creation of network services using CRD based objects: | ||
|
||
* Automatically creating L4LB resources for [services of type LoadBalancer](https://kubernetes.io/docs/tasks/access-application-cluster/create-external-load-balancer/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
L4LB is a not a term widely used in the k8s community.
Use relative path (i.e. /docs/tasks/...
) rather than full path.
Reviewers' comments fixed
Update Netris description
/check-cla |
1 similar comment
/check-cla |
/lgtm |
@thockin I think you are the last reviewer for this one. Thanks! |
@thockin Waiting on your approval for this to get merged. Thanks! |
/hold @tengqm - let's make sure we're clear that this is definitely allowed by the content guide. What was your thinking for determining that it is? |
My $.02 This supporting software solution offers integration with multiple CNCF/LFN projects including FRR/DPDK/k8s/haproxy. These configurations are built to properly route and load balance traffic to the ingress based on a deployment. There will be a free offering of this product announced at Kubecon 2021 in a month. Netris is a supporting member of CNCF and LFN. There are multiple entries in this list which have literally ZERO integration with k8s. This entry offers both CRD and Operator model integrations, as well as integration with Calico for the recommended performance mode design. |
All these entries should be capable of taking a Kubernetes cluster that is missing networking, and implementing the Kubernetes network model (eg: by providing a compatible CNI plugin). We'll accept PRs to remove any entry that doesn't provide Kubernetes-compatible networking. See #20232 |
The "eg" part of your reply is what is confusing. All of these vendors provide creative ways of enabling network functionality either in a CNI or plugin, or via the host networking, or via the actual network itself. If you want to draw the line at only allowing CNIs, then this would mean that the GCE entry should be completely removed, as this does not have a plugin/CNI. In fact this solution requires setting a kernel option to bridge onto the physical network. This entry seems completely orthogonal to a virtualized/containerized system like k8s. Can you clarify what sort of cluster networking services should be admitted to this page? CNIs obviously, but what else? |
This Netris thing looks like a (extended) CNI to me, which is an something one must install in order for making the kubernetes cluster work. According to our previous discussion on 3rd party contents, this one should be okay. By the way, I don't know the technology well. If you have a different opinion, just leave your comments here. |
No it is absolutely not a CNI. Bare metal and NIC subinterface integration only. |
@ixodie Thank you for the clarification. According to our content guide, we don't publish things like this. Please consider closing this PR. |
If Netris does not implement the Kubernetes network model then I agree that Netris should not be added to the /concepts/cluster-administration/networking page according to "What's Allowed" in the Kubernetes Content Guide:
|
With the previous reviews in mind: |
@sftim: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Added description of Netris integration with k8s and included links to solution overview and k8s chart (github).
Content is additive, no conflicts.