Add EventedPLEG to FeatureGates doc #37715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
sig/docs
24 tasks
|
/lgtm |
|
@swghosh: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/lgtm cancel /hold @harche, this PR must target the dev-1.26 branch and not main (which is the live website) Please edit the PR to change its merge base and target branch. |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
removed
the
lgtm
|
/sig node |
k8s-ci-robot
added
the
sig/node
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
removed
the
needs-rebase
|
@sftim I have changed the target branch to Thanks. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
sftim
reviewed
Nov 4, 2022
Comment on lines
895
to
896
| - `EventedPLEG`: Enable `EventedPLEG` for the kubelet. `EventedPLEG` also needs to be enabled in the CRI runtime | ||
| for this feature to work. If the CRI runtime does not implement `EventedPLEG` then kubelet will automatically switch to existing `GenericPLEG` even after enabling this feature. |
There was a problem hiding this comment.
- What is an evented PLEG? Please at least explain the abbreviation.
- You can write
{{< glossary_tooltip text="container runtime" term_id="container-runtime" >}}which renders as “container runtime” with a tooltip and a hyperlink to more info; no need to mention that the runtime is CRI compatible because Kubernetes doesn't support anything else. GenericPLEGisn't a feature gate name, so write “the legacy generic PLEG”.
There was a problem hiding this comment.
@sftim Thanks for your feedback. I made some changes based on it, please let me know what do you think. Thanks.
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
k8s-ci-robot
added
size/XXL
Signed-off-by: Harshal Patil <harpatil@redhat.com>
k8s-ci-robot
added
size/XS
|
/approve |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 3cf4d7a6246d46591eb7af2c76903719351097ca
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: krol3, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/remove-area blog release-eng |
k8s-ci-robot
removed
area/blog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Harshal Patil harpatil@redhat.com
Add EventedPLEG to FeatureGates doc.
Corresponding PR - kubernetes/kubernetes#111384
Enhancement - kubernetes/enhancements#3386