-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bn] Launch Bengali localization #45009
Conversation
/language bn |
✅ Pull request preview available for checking
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold Localization launch needs approval from website admins |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like the change (translation in Bengali) was made by using a translator. Even as a native Bengali speaker, I don't understand most of the terms. Please change 'em
@itsPronay Most of the files are outdated. My team and I are starting fresh. We're working on updating those files and localizing others . Feel free to reach out to me if you notice anything to Change/Update/Localize or if you find any Mistakes . I'll take the necessary steps to fix them. . |
@itsPronay as a courtesy, we avoid reviewing work marked as draft; there are exceptions and I do sometimes offer early feedback. You are welcome to file new issues to record work that needs doing ahead of launching Bengali, including any recommendation to rework something already localized. |
@asem-hamid: No presubmit jobs available for kubernetes/website@main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I also reviewed files outside |
Thank you for addressing my comment |
LGTM label has been added. Git tree hash: bfdef1e6168b1d7177062e43ce0c462ece6be106
|
Thank you for all your hard work on this! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divya-mohan0209 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@seokho-son : Regarding squashing of commits, please could you advise on the precedent followed previously for other localisation go-lives that you have been involved in? |
Hi @divya-mohan0209,
(I assume the following languages were based on a previous localization guide)
However, my concern is not the number of commits but rather the presence of too many redundant or irrelevant commits in dev-1.24-bn.1, possibly included by the GitHub review suggestion UI as well. It seems that many localization teams, including the Korean team, have been making efforts to manage commits effectively. |
I'm okay with it if there have been previous precedents of it working successfully. Again, this is an improvement in how we localise docs that will need general consensus and must be documented. Given the time constraints around the PR, I suggest the following.
|
Although we'd like to see commits done well (it makes the repo easier to manage), if they haven't been then we mostly need to accept that. I am happy to see Bengali launch if the only qualm about launching it is the commit history on that branch and not follow our norms (not rules, norms) around squashing. |
As an aside, watch out for commits that touch other parts of the tree and are then reverted within the same PR. That kind of commit makes merges and rebases a pain for everyone else. (I'm not seeing that here) |
I'm also happy to see the Bengali localization launch and for us to document our desired approach for teams around commits more broadly before stricter reinforcement. Thanks to our various leads for their reviews here! ❤️ |
Ok! I think we've reached a consensus. Let me release the hold and let's look forward to the new language for k8s.io! /lgtm |
Thank you so much for your review, approval, and effort, which allowed us to launch it so quickly. @seokho-son , @reylejano , @divya-mohan0209 , @sftim , @natalisucks |
I also want to thank @seokho-son and @sftim for all the help and guidance from the beginning until now during the localization progress. |
This PR aims to launch the Bengali localization of the Kubernetes website by merging the dev-1.24-bn.1 branch into the main branch.
We have completed all the necessary content and made the required adjustments to launch the Kubernetes website in Bangla.
We also have a perfect deploy preview :
dev-1.24-bn.1 has been fully reviewed by :
@asem-hamid
@mitul3737
@sajibAdhi
We kindly request review and approval from
/cc @a-mccarthy
/cc @seokho-son
/cc @divya-mohan0209
/cc @natalisucks
/cc @reylejano
/cc @sftimThank you for your cooperation and support!