Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bn] Launch Bengali localization #45009

Merged
merged 905 commits into from
May 10, 2024
Merged

[bn] Launch Bengali localization #45009

merged 905 commits into from
May 10, 2024

Conversation

mitul3737
Copy link
Member

@mitul3737 mitul3737 commented Feb 3, 2024

This PR aims to launch the Bengali localization of the Kubernetes website by merging the dev-1.24-bn.1 branch into the main branch.

We have completed all the necessary content and made the required adjustments to launch the Kubernetes website in Bangla.

We also have a perfect deploy preview :

dev-1.24-bn.1 has been fully reviewed by :

@asem-hamid
@mitul3737
@sajibAdhi

We kindly request review and approval from

  • sig-docs-localization-reviewers

/cc @a-mccarthy
/cc @seokho-son

  • sig-docs-leads

/cc @divya-mohan0209
/cc @natalisucks
/cc @reylejano
/cc @sftim

Thank you for your cooperation and support!

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2024
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Feb 3, 2024
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2024
@mitul3737
Copy link
Member Author

/language bn

@k8s-ci-robot k8s-ci-robot added the language/bn Issues or PRs related to Bengali language label Feb 4, 2024
Copy link

netlify bot commented Feb 4, 2024

Pull request preview available for checking

Name Link
🔨 Latest commit 3eced4f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/663d0f00179d1c0008f234cc
😎 Deploy Preview https://deploy-preview-45009--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Feb 4, 2024

/hold

Localization launch needs approval from website admins

Copy link
Contributor

@itsPronay itsPronay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the change (translation in Bengali) was made by using a translator. Even as a native Bengali speaker, I don't understand most of the terms. Please change 'em

@asem-hamid
Copy link
Contributor

@itsPronay Most of the files are outdated. My team and I are starting fresh. We're working on updating those files and localizing others . Feel free to reach out to me if you notice anything to Change/Update/Localize or if you find any Mistakes . I'll take the necessary steps to fix them. .

@sftim
Copy link
Contributor

sftim commented Feb 25, 2024

@itsPronay as a courtesy, we avoid reviewing work marked as draft; there are exceptions and I do sometimes offer early feedback.

You are welcome to file new issues to record work that needs doing ahead of launching Bengali, including any recommendation to rework something already localized.

@k8s-ci-robot
Copy link
Contributor

@asem-hamid: No presubmit jobs available for kubernetes/website@main

In response to this:

/test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

static/_redirects Outdated Show resolved Hide resolved
@reylejano
Copy link
Member

I also reviewed files outside content/bn: OWNERS_ALIASES, README.md, hugo.toml, _redirects. I have one minor suggestion

@reylejano
Copy link
Member

Thank you for addressing my comment
/lgtm
/assign @reylejano @natalisucks @divya-mohan0209 @seokho-son @a-mccarthy

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bfdef1e6168b1d7177062e43ce0c462ece6be106

@divya-mohan0209
Copy link
Contributor

Thank you for all your hard work on this!
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@divya-mohan0209
Copy link
Contributor

@seokho-son : Regarding squashing of commits, please could you advise on the precedent followed previously for other localisation go-lives that you have been involved in?

@seokho-son
Copy link
Member

Hi @divya-mohan0209,
I offered some advice but was not directly involved with the release of previous languages, except for Korean.
I just reviewed how we've managed similar cases in the past.

(I assume the following languages were based on a previous localization guide)

However, my concern is not the number of commits but rather the presence of too many redundant or irrelevant commits in dev-1.24-bn.1, possibly included by the GitHub review suggestion UI as well.

It seems that many localization teams, including the Korean team, have been making efforts to manage commits effectively.

@divya-mohan0209
Copy link
Contributor

I'm okay with it if there have been previous precedents of it working successfully. Again, this is an improvement in how we localise docs that will need general consensus and must be documented. Given the time constraints around the PR, I suggest the following.

  • I'd like the other co-chairs, leads, and emeritus leads to chime in on this improvement as the bare minimum. I'm tagging @reylejano @natalisucks @sftim @a-mccarthy @dipesh-rawat here since they have previously been involved/tagged here for reviews.
  • By EOD, we will proceed with the recommended approach if a minimum quorum of 50% of the folks tagged in point number 1 assent to this improvement without any technical/procedural concerns.
  • If it succeeds without glitches, we will showcase this at our next localisation meeting and PR it as a recommendation in our docs.

@sftim
Copy link
Contributor

sftim commented May 10, 2024

Although we'd like to see commits done well (it makes the repo easier to manage), if they haven't been then we mostly need to accept that.

I am happy to see Bengali launch if the only qualm about launching it is the commit history on that branch and not follow our norms (not rules, norms) around squashing.

@sftim
Copy link
Contributor

sftim commented May 10, 2024

As an aside, watch out for commits that touch other parts of the tree and are then reverted within the same PR. That kind of commit makes merges and rebases a pain for everyone else.

(I'm not seeing that here)

@natalisucks
Copy link
Contributor

I'm also happy to see the Bengali localization launch and for us to document our desired approach for teams around commits more broadly before stricter reinforcement.

Thanks to our various leads for their reviews here! ❤️

@seokho-son
Copy link
Member

Ok! I think we've reached a consensus. Let me release the hold and let's look forward to the new language for k8s.io!

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit 44669d5 into main May 10, 2024
6 checks passed
@asem-hamid
Copy link
Contributor

Thank you so much for your review, approval, and effort, which allowed us to launch it so quickly.

@seokho-son , @reylejano , @divya-mohan0209 , @sftim , @natalisucks

@asem-hamid
Copy link
Contributor

I also want to thank @seokho-son and @sftim for all the help and guidance from the beginning until now during the localization progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/bn Issues or PRs related to Bengali language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.