Skip to content

Conversation

dkarczmarski
Copy link
Contributor

@dkarczmarski dkarczmarski commented Sep 29, 2025

fix truncated text in the diagram on docs/concepts/services-networking/gateway/

EDIT:
preview: https://deploy-preview-52586--kubernetes-io-main-staging.netlify.app/docs/concepts/services-networking/gateway/

fix truncated text in the diagram on docs/concepts/services-networking/gateway/
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 29, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sayakmukhopadhyay for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from lmktfy September 29, 2025 16:32
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Sep 29, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 29, 2025
Copy link

netlify bot commented Sep 29, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 46f02ac
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/68dab4926d724800084d2545
😎 Deploy Preview https://deploy-preview-52586--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Contributor

lmktfy commented Sep 29, 2025

I'm not sure I can see a before and answer difference. Could you provide a raster screenshot pair, showing the improvement?

@dkarczmarski
Copy link
Contributor Author

dkarczmarski commented Sep 30, 2025

I'm not sure I can see a before and answer difference. Could you provide a raster screenshot pair, showing the improvement?

@lmktfy
link with comparison : https://github.com/kubernetes/website/pull/52586/files
the "deleted" side, the 1st and 3rd rectange, "HTTPRoute" has no the last "e", and "GatewayClass" has no the last "s".

this is a screenshot from my ubuntu :
Screenshot from 2025-09-30 08-16-24

EDIT:
if it is ok on your computer, it might be an OS specific issue, caused by different fonts

@salaxander
Copy link
Contributor

I also don't see any difference on my machine, but if it is an improvement on Ubuntu systems I'm fine with it given the images are largely the same.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 30, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 13f9b07310ad9fea12322c3c8a8e60500c9767de

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants