Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sending file messages in Cloud Slack #1412

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix sending file messages in Cloud Slack #1412

merged 1 commit into from
Mar 11, 2024

Conversation

mszostok
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Fix sending AI file response into a given thread
  • Fix setting ack emoji
  • Fix sending empty responses when file doesn't have filter:
 ERRO[2024-03-11T14:24:09+01:00] while sending bot message: 1 error occurred:
     * while sending Slack message to channel "general": while posting Slack message: no_text

Testing

  1. Start a new thread: @Botkube ai hi!
  2. Ask for long msg: @Botkube ai send an example post-mortem document that has at least 3500 chars

Related issue(s)

Fix https://github.com/kubeshop/botkube-cloud/issues/942

@mszostok mszostok added the bug Something isn't working label Mar 11, 2024
@mszostok mszostok requested review from PrasadG193 and a team as code owners March 11, 2024 13:34
@mszostok mszostok requested a review from pkosiec March 11, 2024 13:34
pkosiec
pkosiec approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well 👌

@mszostok mszostok enabled auto-merge (squash) March 11, 2024 19:31
@mszostok mszostok merged commit 97f6bf8 into kubeshop:main Mar 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mszostok @pkosiec