Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide private channel names in show config command #1467

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

pkosiec
Copy link
Member

@pkosiec pkosiec commented Jul 2, 2024

Description

Changes proposed in this pull request:

  • Hide private channel names in show config command
  • Extend config with Cloud Slack channel ID and alias

Preview

image

Testing

Run the changes E2E with other pull requests. Instructions there.

Related issue(s)

https://github.com/kubeshop/botkube-cloud/issues/1165

@pkosiec pkosiec added the enhancement New feature or request label Jul 2, 2024
@pkosiec pkosiec marked this pull request as ready for review July 2, 2024 20:42
@pkosiec pkosiec requested review from PrasadG193 and a team as code owners July 2, 2024 20:42
@pkosiec pkosiec requested a review from mszostok July 2, 2024 20:42
Comment on lines 203 to 204
// ChannelID is the Slack ID of the channel.
ChannelID string `yaml:"channelID"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we have it? Slack is based on channel name 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comment: 0d65e00 👍

@pkosiec pkosiec enabled auto-merge (squash) July 3, 2024 08:09
@pkosiec pkosiec merged commit 9b6b3ce into kubeshop:main Jul 3, 2024
16 checks passed
@pkosiec pkosiec deleted the config-ext branch July 3, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants