Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix onClick propagation in assertion header #601

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix onClick propagation in assertion header #601

merged 1 commit into from
May 31, 2022

Conversation

jorgeepc
Copy link
Contributor

This PR fixes an issue with the onClick propagation in the assertion header.

Changes

  • Fix onClick event.

Fixes

Checklist

  • tested locally
  • added new dependencies
  • updated the docs
  • added a test

@jorgeepc jorgeepc self-assigned this May 31, 2022
cescoferraro
cescoferraro reviewed May 31, 2022
View reviewed changes
Copy link
Contributor

@cescoferraro cescoferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! thanks @jorgeepc

@cescoferraro cescoferraro self-requested a review May 31, 2022 20:43
cescoferraro
cescoferraro approved these changes May 31, 2022
View reviewed changes
Copy link
Contributor

@cescoferraro cescoferraro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jorgeepc jorgeepc merged commit 3bd741d into main May 31, 2022
@jorgeepc jorgeepc deleted the 567-fix-click-propagation branch May 31, 2022 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cescoferraro cescoferraro cescoferraro approved these changes

@xoscar xoscar xoscar approved these changes

Assignees

@jorgeepc jorgeepc

Labels
frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgeepc @cescoferraro @xoscar