-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v23 breaks WebStorm breakpoints #627
Comments
I was struggling with this problem yesterday. Thank you for reporting this issue! |
tested, #626 will fix this (tho you NEED to remove the |
fixed in |
I think can not close this issue, use ts-jest@23.1.2 and jest@23.4.2 breakpoint still not hit, use ts-jest@22.4.6 is work |
Hi @nodece, thanks for the feedback. |
hmmm. I've tested that one with the repo provided by @y0hy0h, just testing again now and it doesn't work... weird. @nodece no need for a minimal repo! Ok, good I waited to post this comment. If you add |
@y0hy0h Thanks. |
UPD: sorry I am wrong, I mistaken with the |
@huafu But generally, if you'd like to have anything changed in the repo, just submit a PR. ;) |
Oh man now re-installing everything and clearing all caches I know of it DOES work!.... |
oooohhh OK found it this is a babel issue, the fix is: babel/babel@21fdaa2 ...now looking at what can be done ts-jest's side |
Use typescript,not use babel, why is the v22.4.6 version available? @huafu |
ts-jest uses babel under the hood for hoisting and also instrumentation. You can look in the git history of babel to find out why it was working in v22, sorry I have no time for this now. I guess jest was adding the sourcemap comment itself in 22... Now working on a fix (which will be a hack) so that we can continue to use babel 6 with breakpoints... |
It fixes kulshekhar#627, but AFAIK there is badly no way of doing a test for that
Issue
v23 breaks WebStorm's ability to set and hit breakpoints.
Expected behavior
Tests should remain debuggable after upgrading to v23.
Output from your debug log
Not created. I set the environment variable
TS_JEST_DEBUG="true"
, but neither the WebStorm run nor the console run (TS_JEST_DEBUG="true" yarn test
) create a file at./node_modules/ts-jest/debug.txt**
.Link to a minimal repo that reproduces this issue
https://github.com/Y0hy0h/ts-jest-debug
Instructions are in the repo's README.
Additional Info
Obviously, this is a breaking change in v23 and it could be considered noting it in issue #601.
The text was updated successfully, but these errors were encountered: