Skip to content

librarian v0.19.1

Choose a tag to compare

@github-actions github-actions released this 16 Oct 20:48
· 38 commits to main since this release

Fixes from a real write flow (blob, tree, commit, ref, pull request)

  • Idempotency keys work everywhere. A repeat with the same idempotency_key was matched in one pod's memory only, so with two replicas a retry on the other pod sent the write again and opened a second approval; grant and automatic writes were never matched at all. The key is now indexed with the write in the database: a repeat returns the earlier result on any replica and after a restart, and a repeat while the first is still pending joins that approval instead of opening another. Failed, denied or expired writes do not block the key.
  • The agent is told how a write ran. Every executed write now carries a message: approved by whom; under which grant (who created it, until when); approved automatically (n of cap today); or not sent again because this key already ran. Grant and automatic writes get an approval id too, so write_status finds them.
  • write_status dates the result. result_as_of and a message say the result is the API's response when the write ran and the resource may have changed since.
  • A decision is stored before waiters see it. A waiter polling at the wrong moment could try to claim a write the database still showed as pending and be told it was "already being run".
  • GitHub SAML enforcement. A 403 "Resource protected by organization SAML enforcement" is explained in the write's error (authorize the token with Configure SSO), and the credential page for GitHub hosts says so up front.
  • Rate limiting is not a permission problem. A 429, or a 403 with X-RateLimit-Remaining: 0, a Retry-After header or a rate-limit message, was reported as "the credential is valid but lacks permission", sending people to check scopes and SSO. It is now reported as rate limiting, with the reset time (from Retry-After or X-RateLimit-Reset) and "retry then", in the error and in the audit record. On any 4xx or 5xx the audit record keeps a short, redacted excerpt of the API's own message (upstream), and the error quotes it.
  • Quieter grants. A grant covering a multi-step flow posted one channel card per step. writes.announce_grants: false (chart: config.writes.announce_grants) stops the post for every grant, and the console's Grants page now has a Notices control to turn it off per grant (notify_owner, which until now only config-file grants could set). On by default. Every use stays in the audit log, the server log and the Activity page.

Upgrade

No configuration changes.