Skip to content

Conversation

berthieresteban
Copy link
Contributor

What does this PR do?

Add vuejs getting-started using vuex
Template and CSS are the same as #405 just move logical part into vuex store

How should this be manually tested?

  • Step 0 : get a Kuzzle running on localhost (without anonymous restrictions)
  • Step 1 : npm install
  • Step 2 : cd doc/6/getting-started/vuejs
  • Step 3 : npm install
  • Step 4 : npm run serve-with-vuex
  • Step 5 : npm run test

Other changes

/

Boyscout

/

@berthieresteban berthieresteban self-assigned this Jul 2, 2019
@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #414 into save-vuejs-getting-started will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                    Coverage Diff                     @@
##           save-vuejs-getting-started    #414   +/-   ##
==========================================================
  Coverage                        96.3%   96.3%           
==========================================================
  Files                              32      32           
  Lines                            1517    1517           
==========================================================
  Hits                             1461    1461           
  Misses                             56      56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a63b6...c709691. Read the comment docs.

commit('ADD_MESSAGE', notification.result);
}
});
commit('SET_ROOMID', roomID);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You set the roomId in the store but you never use it. I think you should unsubscribe this roomId at some point (when the route change for example)

Copy link
Contributor Author

@berthieresteban berthieresteban Jul 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effectively, I did this in the other vuejs gettings-started at line 103, and i explained why I set the roomId in comments because in this little app I don't think its better to weighing the router.
Should I change that in both vuejs getting-started ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just worried people would not understand why we do this in the getting started so I think it would be better, yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I'll do the changes :)

@berthieresteban berthieresteban changed the base branch from 6-dev to save-vuejs-getting-started July 8, 2019 11:31
Copy link
Contributor

@benoitvidis benoitvidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still breaks the documentation build for me:
docker run --rm -t -v $PWD/doc/6:/var/app/src/sdk/js/6 -v /var/app/node_modules/@vuepress/node_modules/.cache-loader -p 8080:8080 kuzzleio/documentation:dev

I must admit I don't have a clear solution for the moment to this issue but it definitely needs to be solved before it is merged to the documentation repository.
Maybe a tweak to exclude html files from the frontmatter plugin would be good enough. I will try that.

[Edit] looks like an exclude pattern is already applied but does not seem to work. I'll look at it.
[Edit] finally looks the issue was coming from the docker image which did not include the exclude pattern. Seems to work far better now.

  • Additionally, the target branch of this PR looks strange to me. Is it the correct one?
  • Aren't we missing an index.md file in the with-vuex directory?

@berthieresteban
Copy link
Contributor Author

berthieresteban commented Jul 9, 2019

@benoitvidis
This PR is only for bring both vuejs getting started on the same branch wich is save-vuejs-getting-started. Of course, we mustn't merge this branch since we resolve the problem !
The index.md will follow in another PR, I don't want you to review thousands additions in one time :p

We made the save branch to remove vuejs getting started of master and allow us to build the doc*

Copy link
Contributor

@benoitvidis benoitvidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok :)

@benoitvidis benoitvidis merged commit 3eda35a into save-vuejs-getting-started Jul 10, 2019
@benoitvidis benoitvidis deleted the add-vuejs-gs-with-vuex branch July 10, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants