Skip to content

Conversation

berthieresteban
Copy link
Contributor

What does this PR do?

Add VueJS getting-started without vuex

How should this be manually tested?

  • Step 0 : get a Kuzzle running on localhost (without anonymous restrictions)
  • Step 1 : npm install
  • Step 2 : cd doc/6/getting-started/vuejs
  • Step 3 : npm install
  • Step 4 : npm run serve-without-vuex
  • Step 5 : npm run test

Other changes

/

Boyscout

/

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #405 into poc-documentation-v6 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           poc-documentation-v6     #405   +/-   ##
=====================================================
  Coverage                 96.31%   96.31%           
=====================================================
  Files                        32       32           
  Lines                      1519     1519           
=====================================================
  Hits                       1463     1463           
  Misses                       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa71e97...b8b2c35. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #405 into poc-documentation-v6 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           poc-documentation-v6     #405   +/-   ##
=====================================================
  Coverage                 96.31%   96.31%           
=====================================================
  Files                        32       32           
  Lines                      1519     1519           
=====================================================
  Hits                       1463     1463           
  Misses                       56       56
Impacted Files Coverage Δ
src/proxify.js 95.23% <0%> (ø) ⬆️
src/controllers/searchResult/base.js 92.85% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa71e97...44e46e0. Read the comment docs.

Copy link
Contributor

@Aschen Aschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last nitpicking

berthieresteban and others added 5 commits July 1, 2019 10:35
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
Co-Authored-By: Adrien Maret <amaret93@gmail.com>
@codecov
Copy link

codecov bot commented Jul 1, 2019

Codecov Report

Merging #405 into poc-documentation-v6 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@                  Coverage Diff                  @@
##           poc-documentation-v6     #405   +/-   ##
=====================================================
  Coverage                 96.31%   96.31%           
=====================================================
  Files                        32       32           
  Lines                      1519     1519           
=====================================================
  Hits                       1463     1463           
  Misses                       56       56

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa71e97...b8b2c35. Read the comment docs.

@xbill82 xbill82 merged commit 9924fab into poc-documentation-v6 Jul 1, 2019
@Aschen Aschen deleted the add-vuejs-getting-started branch July 1, 2019 11:46
berthieresteban added a commit that referenced this pull request Jul 1, 2019
What does this PR do?
just add the requested changes of #405 because removed by #406
@Aschen Aschen mentioned this pull request Jul 1, 2019
This was referenced Jul 25, 2019
scottinet pushed a commit that referenced this pull request Oct 11, 2019
## What does this PR do?

This getting-started has been added to the documentation before but removed because vuepress can't build with it. 

It was approved in those PR : #405 and #406 

Add VueJS getting started without vuex to SDK JS6 documentation.
Resolve the build problem of the vuepress doc (Vuepress tried to build .vue files of the getting-started and crash) by adding symlink.

![image](https://user-images.githubusercontent.com/44427849/62125816-7b1cc180-b2ce-11e9-83e2-df65d7dbcbd4.png)

:warning:  need to add following line in doc/6/getting-started/vuejs/standalone/index.md line 14 after merge: 
``` You can find the full code of this guide [here](https://github.com/kuzzleio/sdk-javascript/tree/6-dev/doc/6/getting-started/vuejs/standalone).```:warning: 


### How should this be manually tested?
See documentation: 
  - Step 1 : npm run doc prepare
  - Step 2 : npm run doc-dev

Test getting started project (You'll need the CYPRESS_RECORD_KEY as environment variable)
  - Step 1 : Get a Kuzzle running without anonymous restrictions
  - Step 2 : cd doc/6/getting-started/vuejs && npm ci
  - Step 3 : npm run serve-standalone
  - Step 4 : npm run test

### Other changes
/

### Boyscout
/
scottinet pushed a commit that referenced this pull request Oct 11, 2019
## What does this PR do?

This getting-started has been added to the documentation before but removed because vuepress can't build with it. 

It was approved in those PR : #405 and #406 

Add VueJS getting started without vuex to SDK JS6 documentation.
Resolve the build problem of the vuepress doc (Vuepress tried to build .vue files of the getting-started and crash) by adding symlink.

![image](https://user-images.githubusercontent.com/44427849/62125816-7b1cc180-b2ce-11e9-83e2-df65d7dbcbd4.png)

:warning:  need to add following line in doc/6/getting-started/vuejs/standalone/index.md line 14 after merge: 
``` You can find the full code of this guide [here](https://github.com/kuzzleio/sdk-javascript/tree/6-dev/doc/6/getting-started/vuejs/standalone).```:warning: 


### How should this be manually tested?
See documentation: 
  - Step 1 : npm run doc prepare
  - Step 2 : npm run doc-dev

Test getting started project (You'll need the CYPRESS_RECORD_KEY as environment variable)
  - Step 1 : Get a Kuzzle running without anonymous restrictions
  - Step 2 : cd doc/6/getting-started/vuejs && npm ci
  - Step 3 : npm run serve-standalone
  - Step 4 : npm run test

### Other changes
/

### Boyscout
/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants