Skip to content

Fix search with size=0 #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2019
Merged

Fix search with size=0 #473

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
27c7317
Fix search with size=0
Aschen Dec 6, 2019
ae1529a
nit
Aschen Dec 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/controllers/document.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ class DocumentController extends BaseController {
delete options[opt];
}

request.size = request.size || 10;
if (request.size === undefined) {
request.size = 10;
}

if (!request.scroll && !request.body.sort && !request.from) {
request.from = 0;
}
Expand Down
17 changes: 17 additions & 0 deletions test/controllers/document.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,23 @@ describe('Document Controller', () => {
});
});

it('should allow to set value of 0 for size', () => {
const result = {
hits: [],
total: 0
};
kuzzle.document.query = sinon.stub().resolves({result});

return kuzzle.document.search('index', 'collection', {}, { size: 0 })
.then(() => {
should(kuzzle.document.query).be.calledOnce();

const request = kuzzle.document.query.getCall(0).args[0];
should(request.from).be.eql(0);
should(request.size).be.eql(0);
});
});

it('should not set default value for from if scroll or sort are specified', () => {
const result = {
hits: [],
Expand Down