Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Dec 6, 2019

What does this PR do?

Fix a bug that prevent user of setting a size of 0 on document.search.

@codecov
Copy link

codecov bot commented Dec 6, 2019

Codecov Report

Merging #473 into 7-dev will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##            7-dev     #473      +/-   ##
==========================================
+ Coverage   96.01%   96.02%   +<.01%     
==========================================
  Files          32       32              
  Lines        1281     1282       +1     
==========================================
+ Hits         1230     1231       +1     
  Misses         51       51
Impacted Files Coverage Δ
src/controllers/document.js 95.16% <100%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 560c46a...ae1529a. Read the comment docs.

@Aschen Aschen merged commit f981efc into 7-dev Dec 6, 2019
@Aschen Aschen deleted the fix-size-default-value branch December 6, 2019 15:13
@Yoann-Abbes Yoann-Abbes mentioned this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants