Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Jan 3, 2020

What does this PR do?

Add the following methods:

Other changes

  • update docker-compose to use elasticsearch:7 meta tag
  • fix refresh argument to accept refresh: false

@codecov
Copy link

codecov bot commented Jan 3, 2020

Codecov Report

Merging #478 into 7-dev will decrease coverage by 0.02%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##            7-dev     #478      +/-   ##
==========================================
- Coverage   96.02%   95.99%   -0.03%     
==========================================
  Files          32       32              
  Lines        1282     1298      +16     
==========================================
+ Hits         1231     1246      +15     
- Misses         51       52       +1
Impacted Files Coverage Δ
src/controllers/security/index.js 99.25% <100%> (+0.04%) ⬆️
src/controllers/auth.js 93.54% <100%> (+0.95%) ⬆️
src/Kuzzle.js 94.04% <50%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d33511...b742906. Read the comment docs.

@Aschen Aschen removed the wip label Jan 3, 2020
Aschen added 2 commits January 3, 2020 18:08
@Aschen Aschen added the 7-dev label Jan 6, 2020

<SinceBadge version="7.1.0" />

<SinceBadge version="Kuzzle 2.1.0" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Food for thoughts: I wonder if instead of this, we should link to the underlying API method instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I remember that we already discuss about adding a link to the original API on each SDK method.
But why did you say that about the Since badge?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't need it if we have links to the underlying API. Moreover, I don't like having to maintain since badges in multiple places, I'd prefer to have only to worry about those badges in the API section of the documentation when updating an API feature.

@scottinet scottinet merged commit fbef509 into 7-dev Jan 8, 2020
@scottinet scottinet deleted the add-api-key-methods branch January 8, 2020 08:19
@Yoann-Abbes Yoann-Abbes mentioned this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants