-
Notifications
You must be signed in to change notification settings - Fork 17
Add API key methods #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API key methods #478
Conversation
Codecov Report
@@ Coverage Diff @@
## 7-dev #478 +/- ##
==========================================
- Coverage 96.02% 95.99% -0.03%
==========================================
Files 32 32
Lines 1282 1298 +16
==========================================
+ Hits 1231 1246 +15
- Misses 51 52 +1
Continue to review full report at Codecov.
|
|
||
<SinceBadge version="7.1.0" /> | ||
|
||
<SinceBadge version="Kuzzle 2.1.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Food for thoughts: I wonder if instead of this, we should link to the underlying API method instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember that we already discuss about adding a link to the original API on each SDK method.
But why did you say that about the Since badge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because we don't need it if we have links to the underlying API. Moreover, I don't like having to maintain since badges in multiple places, I'd prefer to have only to worry about those badges in the API section of the documentation when updating an API feature.
Typo fixes.
What does this PR do?
Add the following methods:
Other changes
elasticsearch:7
meta tagrefresh
argument to acceptrefresh: false