Release 7.1.0 #491
Merged
Release 7.1.0 #491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## What does this PR do? Fix a bug that prevent user of setting a `size` of `0` on `document.search`.
Co-Authored-By: Sébastien Cottinet <scottinet@protonmail.com>
Co-Authored-By: Sébastien Cottinet <scottinet@protonmail.com>
Co-Authored-By: Sébastien Cottinet <scottinet@protonmail.com>
<!-- This template is optional. It simply serves to provide a guide to allow a better review of pull requests. --> <!-- IMPORTANT Don't forget to add the corresponding "changelog:xxx" label to your PR. This is part of our release process in order to generate the change log. --> ## What does this PR do? This PR adds a new `force` option to routes who write a role. It permits not to throw in case you want to set rights about a plugin which is not available yet, or controllers/action that are not described yet in the plugin. :warning: This PR goes along with kuzzleio/kuzzle#1535 As you can see, this option is only effective if it concerns plugin rights. :warning: <!-- Please fulfill this section --> <!-- Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. --> ### How should this be manually tested? :warning: you should test it with Kuzzle instantiated on this branch kuzzleio/kuzzle#1535⚠️ - Try creating this role ``` const body = { controller: { unavailable_plugin/test: { actions: { create: true, update: true } } } } this.sdk.security.createRole('newRole', body) will throw. this.sdk.security.createRole('newRole', body, {force: true}) will work ``` <!-- Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration --> - Step 1 : - Step 2 : - Step 3 : ... ### Other changes <!-- Please describe here all changes not directly linked to the main issue, but made because of it. For instance: issues spotted during this PR and fixed on-the-fly, dependencies update, and so on --> ### Boyscout <!-- Describe here minor improvements in the code base and not directly linked to the main changes: typos fixes, better/new comments, small code simplification, new debug messages, and so on. -->
## What does this PR do? Add the following methods: - [security:createApiKey](https://deploy-preview-478--doc-sdk-javascript.netlify.com/controllers/security/create-api-key/) - [security:deleteApiKey](https://deploy-preview-478--doc-sdk-javascript.netlify.com/controllers/security/delete-api-key/) - [security:searchApiKeys](https://deploy-preview-478--doc-sdk-javascript.netlify.com/controllers/security/search-api-keys/) - [auth:createApiKey](https://deploy-preview-478--doc-sdk-javascript.netlify.com/controllers/auth/create-api-key/) - [auth:deleteApiKey](https://deploy-preview-478--doc-sdk-javascript.netlify.com/controllers/auth/delete-api-key/) - [auth:searchApiKeys](https://deploy-preview-478--doc-sdk-javascript.netlify.com/controllers/auth/search-api-keys/) ### Other changes - update docker-compose to use `elasticsearch:7` meta tag - fix `refresh` argument to accept `refresh: false`
…ument (#479) This PR adds a source option. Set to true returns the updated document in a _source object.
## What does this PR do? Gets rid of `doc/doc.sh` and uses KuzDoc to build the docs. ### How should this be manually tested? Go take a look at the CI job for the dead-link check. To test the build and deploy, you can follow the steps of the [Doc Dev Deploy in the `.travis.yml` file](https://github.com/kuzzleio/sdk-javascript/pull/482/files#diff-354f30a63fb0907d4ad57269548329e3L114) and test them locally.
## What does this PR do?
Allow to pass number as port option to protocols constructors so this will work instead of silently use port `7512`:
```
new WebSocket('localhost', { port: process.env.KUZZLE_PORT })
``
## What does this PR do? When you send a request with arguments that are present in the URL (eg: `/:index/_create`), they are injected in the URL. If the user didn't put the required arguments, they are `undefined` and they end up in the url as the string `"undefined"` (eg: `/undefined/create`). This PR now discard the request if an URL param is missing.
This PR changes the way we get the correct route if there is several of them.
Before this PR:
The SDK checked the size of the url, and chose the shortest.
If they had the same size, it chose the POST route.
And you could not force the verb in your request.
Now:
Same thing, except it chooses the GET route.
Plus, you can force the verb with the option {verb: 'POST'}
Codecov Report
@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 96.02% 95.57% -0.45%
==========================================
Files 32 32
Lines 1282 1312 +30
==========================================
+ Hits 1231 1254 +23
- Misses 51 58 +7
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.1.0 (2020-02-19)
Bug fixes
New features
Enhancements
Others