Fix protocol port option #484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yoann-Abbes
approved these changes
Jan 15, 2020
alexandrebouthinon
approved these changes
Jan 16, 2020
Codecov Report
@@ Coverage Diff @@
## 7-dev #484 +/- ##
====================================
Coverage 96% 96%
====================================
Files 32 32
Lines 1300 1300
====================================
Hits 1248 1248
Misses 52 52Continue to review full report at Codecov.
|
scottinet
approved these changes
Jan 17, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Allow to pass number as port option to protocols constructors so this will work instead of silently use port
7512: