Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Apr 22, 2020

What does this PR do?

⚠️ Depends on kuzzleio/kuzzle#1600

Fix few bugs on the SearchResult pagination with sort and size.

The SDK now support every kind of ES sort:

  • string value
  • array of string
  • array of object

Errors are now thrown when:

  • the sort is invalid
  • the sort combination does not identify one item only

Other changes

  • the next method now return rejected promises instead of throwing (inconsistent behavior that can lead to unhandled rejection)
  • change _uid by _id because this field does not longer exists in ES 7.x

Aschen and others added 5 commits April 22, 2020 10:10
Co-Authored-By: Leonardo D'Aubeterre <bluedraggy@gmail.com>
Co-Authored-By: Leonardo D'Aubeterre <bluedraggy@gmail.com>
@scottinet
Copy link
Contributor

I'm releasing Kuzzle 2.1.4, tests should pass once done.

@Aschen Aschen merged commit 3209ff1 into 7-dev Apr 28, 2020
@Aschen Aschen deleted the fix-search-after branch April 28, 2020 11:53
@Aschen Aschen mentioned this pull request Apr 28, 2020
Aschen added a commit that referenced this pull request Apr 28, 2020
# [7.2.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.2.0) (2020-04-28)


#### Bug fixes

- [ [#508](#508) ] Fix SearchResult.next with sort/size   ([Aschen](https://github.com/Aschen))
- [ [#512](#512) ] Fix token expired   ([Aschen](https://github.com/Aschen))
- [ [#511](#511) ] Avoid to mutate user options   ([Aschen](https://github.com/Aschen))
- [ [#507](#507) ] Fix collection getMapping   ([Aschen](https://github.com/Aschen))

#### New features

- [ [#510](#510) ] Add security:refresh   ([Yoann-Abbes](https://github.com/Yoann-Abbes))

#### Enhancements

- [ [#509](#509) ] Add the rate limit property to Profile objects   ([scottinet](https://github.com/scottinet))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants