-
Notifications
You must be signed in to change notification settings - Fork 17
Fix SearchResult.next with sort/size #508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leodau
reviewed
Apr 22, 2020
Leodau
reviewed
Apr 22, 2020
Leodau
approved these changes
Apr 22, 2020
Co-Authored-By: Leonardo D'Aubeterre <bluedraggy@gmail.com>
Co-Authored-By: Leonardo D'Aubeterre <bluedraggy@gmail.com>
… into fix-search-after
I'm releasing Kuzzle 2.1.4, tests should pass once done. |
Merged
Aschen
added a commit
that referenced
this pull request
Apr 28, 2020
# [7.2.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.2.0) (2020-04-28) #### Bug fixes - [ [#508](#508) ] Fix SearchResult.next with sort/size ([Aschen](https://github.com/Aschen)) - [ [#512](#512) ] Fix token expired ([Aschen](https://github.com/Aschen)) - [ [#511](#511) ] Avoid to mutate user options ([Aschen](https://github.com/Aschen)) - [ [#507](#507) ] Fix collection getMapping ([Aschen](https://github.com/Aschen)) #### New features - [ [#510](#510) ] Add security:refresh ([Yoann-Abbes](https://github.com/Yoann-Abbes)) #### Enhancements - [ [#509](#509) ] Add the rate limit property to Profile objects ([scottinet](https://github.com/scottinet)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix few bugs on the
SearchResult
pagination withsort
andsize
.The SDK now support every kind of ES sort:
Errors are now thrown when:
Other changes
next
method now return rejected promises instead of throwing (inconsistent behavior that can lead to unhandled rejection)_uid
by_id
because this field does not longer exists in ES 7.x