Skip to content

Conversation

scottinet
Copy link
Contributor

@scottinet scottinet commented Apr 22, 2020

Description

Profile contents returned by Kuzzle now have a rateLimit property which was missing from Profile objects returned by this SDK.

This PR adds that missing property to Profile objects.

Boyscout

  • code wrap
  • one var per const/let

@codecov
Copy link

codecov bot commented Apr 22, 2020

Codecov Report

Merging #509 into 7-dev will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            7-dev     #509      +/-   ##
==========================================
+ Coverage   95.79%   95.81%   +0.01%     
==========================================
  Files          32       32              
  Lines        1308     1313       +5     
==========================================
+ Hits         1253     1258       +5     
  Misses         55       55              
Impacted Files Coverage Δ
src/controllers/Security.js 97.10% <100.00%> (+0.02%) ⬆️
src/core/searchResult/Profile.js 100.00% <100.00%> (ø)
src/core/security/Profile.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af9ed6b...51aaaf9. Read the comment docs.

@Leodau Leodau merged commit cfcf343 into 7-dev Apr 23, 2020
@Leodau Leodau deleted the profile-should-contain-rate-limit branch April 23, 2020 20:23
@Aschen Aschen mentioned this pull request Apr 28, 2020
Aschen added a commit that referenced this pull request Apr 28, 2020
# [7.2.0](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.2.0) (2020-04-28)


#### Bug fixes

- [ [#508](#508) ] Fix SearchResult.next with sort/size   ([Aschen](https://github.com/Aschen))
- [ [#512](#512) ] Fix token expired   ([Aschen](https://github.com/Aschen))
- [ [#511](#511) ] Avoid to mutate user options   ([Aschen](https://github.com/Aschen))
- [ [#507](#507) ] Fix collection getMapping   ([Aschen](https://github.com/Aschen))

#### New features

- [ [#510](#510) ] Add security:refresh   ([Yoann-Abbes](https://github.com/Yoann-Abbes))

#### Enhancements

- [ [#509](#509) ] Add the rate limit property to Profile objects   ([scottinet](https://github.com/scottinet))
---
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants