Stick realtime:unsubscribe behavior to documentation
#547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 7-dev #547 +/- ##
==========================================
- Coverage 88.40% 88.39% -0.01%
==========================================
Files 32 32
Lines 1449 1448 -1
Branches 252 252
==========================================
- Hits 1281 1280 -1
Misses 119 119
Partials 49 49
Continue to review full report at Codecov.
|
Yoann-Abbes
changed the title
realtime:unsubscribe return to documentationrealtime:unsubscribe behavior to documentation
scottinet
approved these changes
Oct 2, 2020
Njuelle
approved these changes
Oct 2, 2020
Yoann-Abbes
added a commit
that referenced
this pull request
Oct 13, 2020
What does this PR do? Grammar Fix DeprecatedBadge tags Other Changes Fix e2e tests like there: #547
Merged
scottinet
added a commit
that referenced
this pull request
Oct 28, 2020
# [7.4.1](https://github.com/kuzzleio/sdk-javascript/releases/tag/7.4.1) (2020-10-28) #### Enhancements - [ [#552](#552) ] Upgrade to typescript 4 compatible code ([scottinet](https://github.com/scottinet)) - [ [#551](#551) ] Export interfaces ([Aschen](https://github.com/Aschen)) #### Others - [ [#548](#548) ] [doc] Add a disclaimer about Expo in getting started React Native ([Njuelle](https://github.com/Njuelle)) - [ [#547](#547) ] Stick `realtime:unsubscribe` behavior to documentation ([Yoann-Abbes](https://github.com/Yoann-Abbes)) ---
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Stick behavior of
realtime:unsubscribeto documentationOther change
Fix cypress tests by specifying
CYPRESS_RECORD_KEY_DOCinpackage.jsonand Travis settings.Since by default it uses
CYPRESS_RECORD_KEY, it could not work since it's already used in the AC repo