Release 7.4.1 #553
Merged
Release 7.4.1 #553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly adds empty lines between each snippet and the actual file content. Fixes kuzzleio/documentation#454
What does this PR do? Stick behavior of realtime:unsubscribe to documentation Other change Fix cypress tests by specifying CYPRESS_RECORD_KEY_DOC in package.json and Travis settings. Since by default it uses CYPRESS_RECORD_KEY, it could not work since it's already used in the AC repo
Export types, classes and interfaces declared in interfaces.ts
# Description Fix #549 Update dependencies, and make this SDK compatible with Typescript 4. Errors were all due to WebSocket properties shadowing parent classes getters. # Other changes * Upgrade all dependencies * Upgrade WebPack 4=>5 + configuration upgrade * Deactivate the `no-shadow` eslint rule, and replace it with the dedicated TS one (the vanilla JS "no-shadow" rule doesn't work w/ ts code) * Relax eslint rules for snippets a little, to allow our most recent coding styles in documentation snippets
Codecov Report
@@ Coverage Diff @@
## master #553 +/- ##
==========================================
- Coverage 88.40% 88.39% -0.01%
==========================================
Files 32 32
Lines 1449 1448 -1
Branches 252 252
==========================================
- Hits 1281 1280 -1
Misses 119 119
Partials 49 49
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7.4.1 (2020-10-28)
Enhancements
Others
realtime:unsubscribebehavior to documentation (Yoann-Abbes)