Skip to content

Conversation

Aschen
Copy link
Contributor

@Aschen Aschen commented Dec 5, 2020

What does this PR do?

Rename KuzzleRequest and KuzzleResponse to RequestPayload and ResponsePayload

Also move type definitions to types/

Those types are exactly the same as in Kuzzle.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Dec 5, 2020

This pull request introduces 1 alert when merging 28c65a4 into 63f8fd2 - view on LGTM.com

new alerts:

  • 1 for Superfluous trailing arguments

@codecov
Copy link

codecov bot commented Dec 5, 2020

Codecov Report

Merging #565 (7fd0c4a) into master (76f3e5b) will increase coverage by 0.01%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
+ Coverage   88.34%   88.36%   +0.01%     
==========================================
  Files          32       32              
  Lines        1442     1444       +2     
  Branches      251      252       +1     
==========================================
+ Hits         1274     1276       +2     
  Misses        119      119              
  Partials       49       49              
Impacted Files Coverage Δ
src/controllers/Auth.ts 75.64% <ø> (ø)
src/controllers/Base.ts 87.50% <0.00%> (ø)
src/controllers/Collection.ts 75.43% <ø> (ø)
src/controllers/Document.ts 71.59% <ø> (ø)
src/controllers/Realtime.ts 90.47% <ø> (ø)
src/core/searchResult/Document.ts 100.00% <ø> (ø)
src/core/searchResult/SearchResultBase.ts 77.19% <0.00%> (ø)
src/core/searchResult/Specifications.ts 100.00% <ø> (ø)
src/core/security/Profile.ts 100.00% <ø> (ø)
src/core/security/Role.ts 71.42% <ø> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76f3e5b...7fd0c4a. Read the comment docs.

@Aschen Aschen merged commit 731b99f into master Dec 7, 2020
@Aschen Aschen deleted the rename-kuzzle-request branch December 7, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants