Skip to content

Commit e6bcdd2

Browse files
yosrym93sean-jc
authored andcommitted
KVM: selftests: Extend vmx_nested_tsc_scaling_test to cover SVM
Add SVM L1 code to run the nested guest, and allow the test to run with SVM as well as VMX. Signed-off-by: Yosry Ahmed <yosry.ahmed@linux.dev> Link: https://patch.msgid.link/20251021074736.1324328-5-yosry.ahmed@linux.dev Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent 0a9eb2a commit e6bcdd2

File tree

2 files changed

+44
-6
lines changed

2 files changed

+44
-6
lines changed

tools/testing/selftests/kvm/Makefile.kvm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,7 @@ TEST_GEN_PROGS_x86 += x86/msrs_test
9191
TEST_GEN_PROGS_x86 += x86/nested_close_kvm_test
9292
TEST_GEN_PROGS_x86 += x86/nested_emulation_test
9393
TEST_GEN_PROGS_x86 += x86/nested_exceptions_test
94+
TEST_GEN_PROGS_x86 += x86/nested_tsc_scaling_test
9495
TEST_GEN_PROGS_x86 += x86/platform_info_test
9596
TEST_GEN_PROGS_x86 += x86/pmu_counters_test
9697
TEST_GEN_PROGS_x86 += x86/pmu_event_filter_test
@@ -118,7 +119,6 @@ TEST_GEN_PROGS_x86 += x86/vmx_msrs_test
118119
TEST_GEN_PROGS_x86 += x86/vmx_invalid_nested_guest_state
119120
TEST_GEN_PROGS_x86 += x86/vmx_set_nested_state_test
120121
TEST_GEN_PROGS_x86 += x86/vmx_tsc_adjust_test
121-
TEST_GEN_PROGS_x86 += x86/vmx_nested_tsc_scaling_test
122122
TEST_GEN_PROGS_x86 += x86/apic_bus_clock_test
123123
TEST_GEN_PROGS_x86 += x86/xapic_ipi_test
124124
TEST_GEN_PROGS_x86 += x86/xapic_state_test

tools/testing/selftests/kvm/x86/vmx_nested_tsc_scaling_test.c renamed to tools/testing/selftests/kvm/x86/nested_tsc_scaling_test.c

Lines changed: 43 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
#include "kvm_util.h"
1515
#include "vmx.h"
16+
#include "svm_util.h"
1617
#include "kselftest.h"
1718

1819
/* L2 is scaled up (from L1's perspective) by this factor */
@@ -79,7 +80,30 @@ static void l2_guest_code(void)
7980
__asm__ __volatile__("vmcall");
8081
}
8182

82-
static void l1_guest_code(struct vmx_pages *vmx_pages)
83+
static void l1_svm_code(struct svm_test_data *svm)
84+
{
85+
unsigned long l2_guest_stack[L2_GUEST_STACK_SIZE];
86+
87+
/* check that L1's frequency looks alright before launching L2 */
88+
check_tsc_freq(UCHECK_L1);
89+
90+
generic_svm_setup(svm, l2_guest_code,
91+
&l2_guest_stack[L2_GUEST_STACK_SIZE]);
92+
93+
/* enable TSC scaling for L2 */
94+
wrmsr(MSR_AMD64_TSC_RATIO, L2_SCALE_FACTOR << 32);
95+
96+
/* launch L2 */
97+
run_guest(svm->vmcb, svm->vmcb_gpa);
98+
GUEST_ASSERT(svm->vmcb->control.exit_code == SVM_EXIT_VMMCALL);
99+
100+
/* check that L1's frequency still looks good */
101+
check_tsc_freq(UCHECK_L1);
102+
103+
GUEST_DONE();
104+
}
105+
106+
static void l1_vmx_code(struct vmx_pages *vmx_pages)
83107
{
84108
unsigned long l2_guest_stack[L2_GUEST_STACK_SIZE];
85109
uint32_t control;
@@ -116,11 +140,19 @@ static void l1_guest_code(struct vmx_pages *vmx_pages)
116140
GUEST_DONE();
117141
}
118142

143+
static void l1_guest_code(void *data)
144+
{
145+
if (this_cpu_has(X86_FEATURE_VMX))
146+
l1_vmx_code(data);
147+
else
148+
l1_svm_code(data);
149+
}
150+
119151
int main(int argc, char *argv[])
120152
{
121153
struct kvm_vcpu *vcpu;
122154
struct kvm_vm *vm;
123-
vm_vaddr_t vmx_pages_gva;
155+
vm_vaddr_t guest_gva = 0;
124156

125157
uint64_t tsc_start, tsc_end;
126158
uint64_t tsc_khz;
@@ -129,7 +161,8 @@ int main(int argc, char *argv[])
129161
uint64_t l1_tsc_freq = 0;
130162
uint64_t l2_tsc_freq = 0;
131163

132-
TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_VMX));
164+
TEST_REQUIRE(kvm_cpu_has(X86_FEATURE_VMX) ||
165+
kvm_cpu_has(X86_FEATURE_SVM));
133166
TEST_REQUIRE(kvm_has_cap(KVM_CAP_TSC_CONTROL));
134167
TEST_REQUIRE(sys_clocksource_is_based_on_tsc());
135168

@@ -152,8 +185,13 @@ int main(int argc, char *argv[])
152185
printf("real TSC frequency is around: %"PRIu64"\n", l0_tsc_freq);
153186

154187
vm = vm_create_with_one_vcpu(&vcpu, l1_guest_code);
155-
vcpu_alloc_vmx(vm, &vmx_pages_gva);
156-
vcpu_args_set(vcpu, 1, vmx_pages_gva);
188+
189+
if (kvm_cpu_has(X86_FEATURE_VMX))
190+
vcpu_alloc_vmx(vm, &guest_gva);
191+
else
192+
vcpu_alloc_svm(vm, &guest_gva);
193+
194+
vcpu_args_set(vcpu, 1, guest_gva);
157195

158196
tsc_khz = __vcpu_ioctl(vcpu, KVM_GET_TSC_KHZ, NULL);
159197
TEST_ASSERT(tsc_khz != -1, "vcpu ioctl KVM_GET_TSC_KHZ failed");

0 commit comments

Comments
 (0)