Allow casting from String -> Double when checking timestamps #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not all server-side JWT packages drop the quotes around returned values, which causes a decoding error to occur because `as? NSTimeInterval` will fail on strings.
|
Thanks @parrots. Can you add a small test to ensure that this works as intended? You just be able to copy https://github.com/kylef/JSONWebToken.swift/blob/master/JWTTests/JWTTests.swift#L127-L133 and modify it slightly. |
kylef
added a commit
that referenced
this pull request
Oct 1, 2015
Allow casting from String -> Double when checking timestamps
|
Thanks @parrots! |
|
No problem, thanks for the library! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not all server-side JWT packages drop the quotes around returned values. If a timestamp is returned with quotes a decoding error will occur because
as? NSTimeIntervalwill fail on strings. This will also attempt to parse strings to a double value and use that as the timestamp.(Ideally this would be a change for the JSON parser, but that isn't something we can control)