Add the note and minor corrections in the main README.md document #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazydek
requested review from
a-thaler,
bszwarc,
clebs,
klaudiagrz,
lilitgh,
suleymanakbas91 and
tomekpapiernik
as code owners
2 tasks
derberg
reviewed
Nov 8, 2018
README.md
Outdated
| @@ -19,17 +19,19 @@ The examples project provides a central repository to showcase and illustrate fe | |||
|
|
|||
| The summary of the documentation in the `examples` repository lists all available examples organized by the feature or concept they showcase. This structure provides a quick overview and easy navigation. | |||
|
|
|||
| >**NOTE:** The table with examples is also available under `docs` in the `kyma` repository. Whenever you update the table, modify the [Overview](https://github.com/kyma-project/kyma/blob/master/docs/kyma/docs/007-overview-examples.md) document accordingly. | |||
There was a problem hiding this comment.
Please make it a hidden html comment that is visible only to the editors
like
derberg
approved these changes
Nov 8, 2018
klaudiagrz
reviewed
Nov 8, 2018
README.md
Outdated
| @@ -19,17 +19,19 @@ The examples project provides a central repository to showcase and illustrate fe | |||
|
|
|||
| The summary of the documentation in the `examples` repository lists all available examples organized by the feature or concept they showcase. This structure provides a quick overview and easy navigation. | |||
|
|
|||
| <!-- NOTE: The table with examples is also available in the kyma repository. Whenever you update the table, modify this Overview document accordingly: https://github.com/kyma-project/kyma/blob/master/docs/kyma/docs/007-overview-examples.md. --> | |||
There was a problem hiding this comment.
Suggested change
| <!-- NOTE: The table with examples is also available in the kyma repository. Whenever you update the table, modify this Overview document accordingly: https://github.com/kyma-project/kyma/blob/master/docs/kyma/docs/007-overview-examples.md. --> | |
| <!-- NOTE: The table with examples is also available in the `kyma` repository. Whenever you update the table, modify this Overview document accordingly: https://github.com/kyma-project/kyma/blob/master/docs/kyma/docs/007-overview-examples.md. --> |
There was a problem hiding this comment.
Actually, I didn't add it intentionally as it is a hidden comment that does not render in a preview, thus markdown formatting is not required here.
There was a problem hiding this comment.
Let's change it to "kyma" repository.
call-ec/README.md
Outdated
| To access the UI, go to `http://localhost:3000` and authenticate in Enterprise Commerce. After you authenticate, the system redirects you back to the Web UI application. | ||
| Find the access token and the ID token issued for your application by Enterprise Commerce in the **Authentication** section. Expand **The Function** section to call the function and check the results of the operation. | ||
| To access the UI, go to `http://localhost:3000` and authenticate in SAP Commerce. After you authenticate, the system redirects you back to the Web UI application. | ||
| Find the access token and the ID token issued for your application by SAP Commerce in the **Authentication** section. Expand **The Function** section to call the Function and check the results of the operation. |
There was a problem hiding this comment.
Suggested change
| Find the access token and the ID token issued for your application by SAP Commerce in the **Authentication** section. Expand **The Function** section to call the Function and check the results of the operation. | |
| Find the access token and the ID token issued for your application by SAP Commerce in the **Authentication** section. Expand **The Function** section to call the Function and check the results of the operation. |
Are you sure we capitalize Function?
klaudiagrz
approved these changes
Nov 8, 2018
suleymanakbas91
approved these changes
Nov 9, 2018
added 8 commits
November 12, 2018 14:43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
kymarepository and the need to update it when the examples table is changed.Related issue(s)
Relates to #24