Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"All Unreads" section headings unstyled #150

Closed
Line-Noise opened this issue Mar 19, 2018 · 3 comments
Closed

"All Unreads" section headings unstyled #150

Line-Noise opened this issue Mar 19, 2018 · 3 comments
Labels
styling

Comments

@Line-Noise
Copy link

When using keyboard shortcuts for "All Unreads" (Enter to show unreads, r to mark as read) the channel section headings are unstyled. The class for the div is unread_group_header display_flex justify_content_between.
@laCour laCour added the styling label Apr 6, 2018
@mastermel
Copy link
Collaborator

Hey @Line-Noise, I'm not super familiar with the keyboard controls for "All Unreads", but examining that part of Slack on the latest version today it appears that the channel headers are being themed correctly. If that's not the case, can you re-open this and include a screenshot of what you're seeing?

@Line-Noise
Copy link
Author

screenshot from 2018-05-17 09-48-15

I have the latest version installed on May 14. It's still happening. I've attached a screenshot.

  • If you have multiple channels with unread messages click on All Unreads at the top of the Channel list pane.
  • A list of channels and unread messages will be displayed in the message pane.
  • On your keyboard hit the r key to mark the first unread channel as "read".
  • That channel will collapse and the next unread channel will be highlighted.
  • This new highlighted channel name line is unstyled. (Note, clicking on the "Mark as Read" button will style the channel header correctly. Only the keyboard shortcut causes it.)
  • The remaining read and unread channels will be styled correctly (apart from the "Mark as Read" button).

Thanks for your work on this theme! It makes Slack usable without burning out my retinas!

@mastermel
Copy link
Collaborator

Awesome, thank you @Line-Noise, I'll look for an opportunity to repro and fix!

@mastermel mastermel reopened this May 17, 2018
Zoooook pushed a commit to Zoooook/slack-night-mode that referenced this issue Jul 3, 2020
@mastermel
correct colors for unread section headers
c244f67 
Fixes laCour#150

Before: https://cl.ly/3T0V2z3h2U41
After:  https://cl.ly/3T0V2z3h2U41

Test Plan:
- Have two or more un-muted channels containing new messages
- Click on "All Unreads" and click the first channel header (collapsing it)
- Press the "r" key to mark that channel as read
- Notice the focus is now moved to the next unread section
- Verify that the focused section has a dark background, and that the
  buttons and text appear correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
styling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@laCour @Line-Noise @mastermel