Skip to content
This repository has been archived by the owner on Nov 29, 2019. It is now read-only.

reorganise tests, to enable testing several models #5

Closed
wants to merge 1 commit into from

Conversation

sbarthelemy
Copy link

No description provided.

@olivier-stasse
Copy link
Member

Hi Sebastien,
I really like the idea.
But common.hh has the robot model hard-coded l.33
whereas test_rnea.cc and test_crba.cc are very generic.

We can probably go further by moving common.hh to a specific robot directory,
and compile test_rnea.cc and test_crba,cc with different TEST_DIRECTORY and
common.hh by changing the include directories.

For now I will pull the commit as it is.

@ghost ghost assigned olivier-stasse Aug 3, 2012
@sbarthelemy
Copy link
Author

But common.hh has the robot model hard-coded l.33

Yes, my plan was to add other #include lines while we add robots, since they all have a sub-namespace, there won't be any collision. But this is not very good looking indeed.

We can probably go further by moving common.hh to a specific robot directory,
and compile test_rnea.cc and test_crba,cc with different TEST_DIRECTORY and
common.hh by changing the include directories.

I'll think about it, I'd like to avoid duplicating the code in common.hh. But it can be easily generated from cmake.

For now I will pull the commit as it is.

Good, thanks

@olivier-stasse
Copy link
Member

Test and merged by commit 804a

To keep a linear branch, I will not rely on the github interface to perform the merge.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants