-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement gql_mutation_wrapper()
function
#2164
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced May 21, 2024
github-actions
bot
added
comp:manager
Related to Manager component
size:M
30~100 LoC
labels
May 21, 2024
This was referenced May 21, 2024
kyujin-cho
force-pushed
the
topic/fix-column-name-typo
branch
from
May 21, 2024 11:23
080fd28
to
43bce02
Compare
kyujin-cho
force-pushed
the
topic/implement-gql_mutation_wrapper
branch
2 times, most recently
from
May 22, 2024 06:15
860dc77
to
3a35472
Compare
kyujin-cho
force-pushed
the
topic/implement-gql_mutation_wrapper
branch
2 times, most recently
from
May 24, 2024 06:47
a133c1d
to
5ba89ca
Compare
kyujin-cho
added
the
skip:changelog
Make the action workflow to skip towncrier check
label
May 24, 2024
— with
Graphite App
kyujin-cho
force-pushed
the
topic/fix-column-name-typo
branch
from
May 28, 2024 02:27
17e8e71
to
29ad86d
Compare
kyujin-cho
force-pushed
the
topic/implement-gql_mutation_wrapper
branch
2 times, most recently
from
May 28, 2024 02:33
40f6597
to
1fef8e9
Compare
kyujin-cho
force-pushed
the
topic/implement-gql_mutation_wrapper
branch
2 times, most recently
from
May 28, 2024 03:59
20b0432
to
1c98c0f
Compare
kyujin-cho
force-pushed
the
topic/implement-gql_mutation_wrapper
branch
2 times, most recently
from
May 28, 2024 05:21
794c12a
to
1a967e9
Compare
Merge activity
|
This PR implements new `gql_mutation_wrapper()` to get rid of logics duplicated at `simple_db_mutate_returning_item()` and `simple_db_mutate()` and to allow GQL Mutation resolvers higher level of customization.
kyujin-cho
force-pushed
the
topic/fix-column-name-typo
branch
from
May 28, 2024 05:37
9c3bb50
to
92f7df1
Compare
kyujin-cho
force-pushed
the
topic/implement-gql_mutation_wrapper
branch
from
May 28, 2024 05:38
1a967e9
to
3d5d53a
Compare
lablup-octodog
pushed a commit
that referenced
this pull request
May 28, 2024
This PR implements new to get rid of logics duplicated at and and to allow GQL Mutation resolvers higher level of customization. Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2164
kyujin-cho
added a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com> Backported-from: main (24.09) Backported-to: 24.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
comp:manager
Related to Manager component
size:M
30~100 LoC
skip:changelog
Make the action workflow to skip towncrier check
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements new
gql_mutation_wrapper()
to get rid of logics duplicated atsimple_db_mutate_returning_item()
andsimple_db_mutate()
and to allow GQL Mutation resolvers higher level of customization.