Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement gql_mutation_wrapper() function #2164

Merged
merged 1 commit into from
May 28, 2024

Conversation

kyujin-cho
Copy link
Member

@kyujin-cho kyujin-cho commented May 21, 2024

This PR implements new gql_mutation_wrapper() to get rid of logics duplicated at simple_db_mutate_returning_item() and simple_db_mutate() and to allow GQL Mutation resolvers higher level of customization.

Copy link

graphite-app bot commented May 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added comp:manager Related to Manager component size:M 30~100 LoC labels May 21, 2024
@kyujin-cho kyujin-cho force-pushed the topic/implement-gql_mutation_wrapper branch 2 times, most recently from 860dc77 to 3a35472 Compare May 22, 2024 06:15
@kyujin-cho kyujin-cho force-pushed the topic/implement-gql_mutation_wrapper branch 2 times, most recently from a133c1d to 5ba89ca Compare May 24, 2024 06:47
@kyujin-cho kyujin-cho added the skip:changelog Make the action workflow to skip towncrier check label May 24, 2024 — with Graphite App
@kyujin-cho kyujin-cho force-pushed the topic/implement-gql_mutation_wrapper branch 2 times, most recently from 40f6597 to 1fef8e9 Compare May 28, 2024 02:33
@kyujin-cho kyujin-cho added this to the 24.03 milestone May 28, 2024
@kyujin-cho kyujin-cho force-pushed the topic/implement-gql_mutation_wrapper branch 2 times, most recently from 20b0432 to 1c98c0f Compare May 28, 2024 03:59
@kyujin-cho kyujin-cho added size:M 30~100 LoC and removed size:M 30~100 LoC labels May 28, 2024
@kyujin-cho kyujin-cho force-pushed the topic/implement-gql_mutation_wrapper branch 2 times, most recently from 794c12a to 1a967e9 Compare May 28, 2024 05:21
Copy link

graphite-app bot commented May 28, 2024

Merge activity

This PR implements new `gql_mutation_wrapper()` to get rid of logics duplicated at `simple_db_mutate_returning_item()` and `simple_db_mutate()` and to allow GQL Mutation resolvers higher level of customization.
@kyujin-cho kyujin-cho force-pushed the topic/implement-gql_mutation_wrapper branch from 1a967e9 to 3d5d53a Compare May 28, 2024 05:38
@kyujin-cho kyujin-cho changed the base branch from topic/fix-column-name-typo to main May 28, 2024 05:43
@graphite-app graphite-app bot merged commit 3d5d53a into main May 28, 2024
31 checks passed
@graphite-app graphite-app bot deleted the topic/implement-gql_mutation_wrapper branch May 28, 2024 05:44
lablup-octodog pushed a commit that referenced this pull request May 28, 2024
This PR implements new  to get rid of logics duplicated at  and  and to allow GQL Mutation resolvers higher level of customization.

Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2164
kyujin-cho added a commit that referenced this pull request May 28, 2024
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com>
Backported-from: main (24.09)
Backported-to: 24.03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:manager Related to Manager component size:M 30~100 LoC skip:changelog Make the action workflow to skip towncrier check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant