Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for mounting extra vfolders to model service session #2168

Merged
merged 1 commit into from
May 28, 2024

Conversation

kyujin-cho
Copy link
Member

@kyujin-cho kyujin-cho commented May 21, 2024

This PR implements support for mounting arbitrary virtual folders on model service session.


📚 Documentation preview 📚: https://sorna--2168.org.readthedocs.build/en/2168/


📚 Documentation preview 📚: https://sorna-ko--2168.org.readthedocs.build/ko/2168/


📚 Documentation preview 📚: https://sorna--2168.org.readthedocs.build/en/2168/


📚 Documentation preview 📚: https://sorna-ko--2168.org.readthedocs.build/ko/2168/

Copy link

graphite-app bot commented May 21, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added area:docs Documentations comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC labels May 21, 2024
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 0ed50df to fb592b7 Compare May 21, 2024 11:23
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 47cb789 to 2e07266 Compare May 21, 2024 11:24
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from fb592b7 to eec25ff Compare May 21, 2024 11:24
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 2e07266 to d973914 Compare May 21, 2024 11:24
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from eec25ff to 1849e9c Compare May 22, 2024 06:15
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from d973914 to 6bb2add Compare May 22, 2024 06:15
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 1849e9c to 0343ba3 Compare May 22, 2024 09:20
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 40a3300 to d82ba12 Compare May 22, 2024 09:20
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 0343ba3 to 3957ba6 Compare May 22, 2024 09:26
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from d82ba12 to ace548f Compare May 22, 2024 09:26
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 3957ba6 to 74bfa7f Compare May 22, 2024 09:27
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from ace548f to 4955e6b Compare May 22, 2024 09:27
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 74bfa7f to 07c70e8 Compare May 22, 2024 09:28
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 4955e6b to 80f6bfd Compare May 22, 2024 09:28
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 07c70e8 to 410de08 Compare May 22, 2024 09:34
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 80f6bfd to d62f374 Compare May 22, 2024 09:34
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 410de08 to c64ea10 Compare May 24, 2024 06:47
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from e7fc9d3 to 1a85060 Compare May 28, 2024 03:09
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch 3 times, most recently from 8a1ade8 to 91482ff Compare May 28, 2024 03:20
@kyujin-cho kyujin-cho added size:L 100~500 LoC and removed size:L 100~500 LoC labels May 28, 2024
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 466ffca to b9c9179 Compare May 28, 2024 03:59
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 8a57e67 to 76fa1ea Compare May 28, 2024 03:59
@kyujin-cho kyujin-cho added size:L 100~500 LoC area:docs Documentations and removed size:L 100~500 LoC area:docs Documentations labels May 28, 2024
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 41ff385 to 67ea542 Compare May 28, 2024 05:06
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 622ab57 to 8cfe0f1 Compare May 28, 2024 05:06
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 67ea542 to 287ae45 Compare May 28, 2024 05:21
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 8cfe0f1 to 132bd3d Compare May 28, 2024 05:21
Copy link

graphite-app bot commented May 28, 2024

Merge activity

#2168)

This PR implements support for mounting arbitrary virtual folders on model service session.

<!-- readthedocs-preview sorna start -->
----
📚 Documentation preview 📚: https://sorna--2168.org.readthedocs.build/en/2168/

<!-- readthedocs-preview sorna end -->

<!-- readthedocs-preview sorna-ko start -->
----
📚 Documentation preview 📚: https://sorna-ko--2168.org.readthedocs.build/ko/2168/

<!-- readthedocs-preview sorna-ko end -->
@kyujin-cho kyujin-cho force-pushed the topic/add-validation-logic-to-modify-endpoint branch from 287ae45 to 2abd2b6 Compare May 28, 2024 05:39
@kyujin-cho kyujin-cho force-pushed the topic/add-support-for-extra-mounts branch from 132bd3d to 1b81caa Compare May 28, 2024 05:40
@kyujin-cho kyujin-cho changed the base branch from topic/add-validation-logic-to-modify-endpoint to main May 28, 2024 05:47
@graphite-app graphite-app bot merged commit 1b81caa into main May 28, 2024
31 checks passed
@graphite-app graphite-app bot deleted the topic/add-support-for-extra-mounts branch May 28, 2024 05:48
lablup-octodog pushed a commit that referenced this pull request May 28, 2024
#2168)

This PR implements support for mounting arbitrary virtual folders on model service session.

<!-- readthedocs-preview sorna start -->
----
📚 Documentation preview 📚: https://sorna--2168.org.readthedocs.build/en/2168/

<!-- readthedocs-preview sorna end -->

<!-- readthedocs-preview sorna-ko start -->
----
📚 Documentation preview 📚: https://sorna-ko--2168.org.readthedocs.build/ko/2168/

<!-- readthedocs-preview sorna-ko end -->

Backported-from: main (24.09)
Backported-to: 24.03
Backport-of: 2168
kyujin-cho added a commit that referenced this pull request May 28, 2024
#2168)

This PR implements support for mounting arbitrary virtual folders on model service session.

<!-- readthedocs-preview sorna start -->
----
📚 Documentation preview 📚: https://sorna--2168.org.readthedocs.build/en/2168/

<!-- readthedocs-preview sorna end -->

<!-- readthedocs-preview sorna-ko start -->
----
📚 Documentation preview 📚: https://sorna-ko--2168.org.readthedocs.build/ko/2168/

<!-- readthedocs-preview sorna-ko end -->
kyujin-cho pushed a commit that referenced this pull request May 28, 2024
#2168)

Backported-from: main (24.09)
Backported-to: 24.03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:docs Documentations comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants