feat: model service validation process for ModifyEndpoint
#2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced May 21, 2024
github-actions
bot
added
comp:manager
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
944a78a
to
8066871
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
0ed50df
to
fb592b7
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
8066871
to
15a05b3
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
fb592b7
to
eec25ff
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
15a05b3
to
4d00610
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
eec25ff
to
1849e9c
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
0dc0ee3
to
74f7e89
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
5 times, most recently
from
07c70e8
to
410de08
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
74f7e89
to
67ce42a
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
410de08
to
c64ea10
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
67ce42a
to
9ba8f27
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
c64ea10
to
70d894b
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
9ba8f27
to
feea245
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
70d894b
to
1614182
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
9faf007
to
a710959
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
1614182
to
54089bf
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
a710959
to
8a5191e
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
54089bf
to
e7fc9d3
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
8a5191e
to
f7f3b8e
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
e7fc9d3
to
1a85060
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
f7f3b8e
to
ba6b622
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
466ffca
to
b9c9179
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
cc39a70
to
e24d983
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
41ff385
to
67ea542
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
e24d983
to
6a49614
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
67ea542
to
287ae45
Compare
Merge activity
|
This PR updates `ModifyEndpoint` so that it can perform same service validation process with service creation process. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Milestone metadata specifying the target backport version - [ ] Mention to the original issue - [ ] Installer updates including: - Fixtures for db schema changes - New mandatory config options - [ ] Update of end-to-end CLI integration tests in `ai.backend.test` - [ ] API server-client counterparts (e.g., manager API -> client SDK) - [ ] Test case(s) to: - Demonstrate the difference of before/after - Demonstrate the flow of abstract/conceptual models with a concrete implementation - [ ] Documentation - Contents in the `docs` directory - docstrings in public interfaces and type annotations
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
6a49614
to
42e9419
Compare
kyujin-cho
force-pushed
the
topic/add-validation-logic-to-modify-endpoint
branch
from
287ae45
to
2abd2b6
Compare
kyujin-cho
changed the base branch from
topic/split-out-predicate-checker
to
main
graphite-app
bot
deleted the
topic/add-validation-logic-to-modify-endpoint
branch
lablup-octodog
pushed a commit
that referenced
this pull request
May 28, 2024
This PR updates so that it can perform same service validation process with service creation process. --- <!-- Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes, and how it affects the users and other developers. --> **Checklist:** (if applicable) - [ ] Milestone metadata specifying the target backport version - [ ] Mention to the original issue - [ ] Installer updates including: - Fixtures for db schema changes - New mandatory config options - [ ] Update of end-to-end CLI integration tests in - [ ] API server-client counterparts (e.g., manager API -> client SDK) - [ ] Test case(s) to: - Demonstrate the difference of before/after - Demonstrate the flow of abstract/conceptual models with a concrete implementation - [ ] Documentation - Contents in the directory - docstrings in public interfaces and type annotations Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2167
kyujin-cho
added a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: kyujin-cho <thy2134@me.com> Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com> Backported-from: main (24.09) Backported-to: 24.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
ModifyEndpointso that it can perform same service validation process with service creation process.Checklist: (if applicable)
ai.backend.testdocsdirectory