feat: split out predicate check logic #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 21, 2024
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
7 tasks
github-actions
bot
added
area:docs
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
b53bea0
to
7b24049
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
944a78a
to
8066871
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
7b24049
to
62016a8
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
8066871
to
15a05b3
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
62016a8
to
d01e758
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
15a05b3
to
4d00610
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
c51638a
to
e95b196
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
0dc0ee3
to
74f7e89
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
e95b196
to
a2fddfe
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
2 times, most recently
from
67ce42a
to
9ba8f27
Compare
kyujin-cho
added
the
skip:changelog
Graphite App
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
9906598
to
bf18603
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
9ba8f27
to
feea245
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
e4bd506
to
52f6c34
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
2 times, most recently
from
a710959
to
8a5191e
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
75333e1
to
01066e7
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
8a5191e
to
f7f3b8e
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
01066e7
to
422bd3b
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
f7f3b8e
to
ba6b622
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
610d899
to
1e8c2e2
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
cc39a70
to
e24d983
Compare
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
1e8c2e2
to
137326e
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
e24d983
to
6a49614
Compare
Merge activity
|
This PR abstracts model service validation logic to another class so that it can be reused on consequent occurrences. <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2166.org.readthedocs.build/en/2166/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2166.org.readthedocs.build/ko/2166/ <!-- readthedocs-preview sorna-ko end -->
kyujin-cho
force-pushed
the
topic/virtual-folder-node
branch
from
137326e
to
7b0b9d3
Compare
kyujin-cho
force-pushed
the
topic/split-out-predicate-checker
branch
from
6a49614
to
42e9419
Compare
lablup-octodog
pushed a commit
that referenced
this pull request
May 28, 2024
This PR abstracts model service validation logic to another class so that it can be reused on consequent occurrences. <!-- readthedocs-preview sorna start --> ---- 📚 Documentation preview 📚: https://sorna--2166.org.readthedocs.build/en/2166/ <!-- readthedocs-preview sorna end --> <!-- readthedocs-preview sorna-ko start --> ---- 📚 Documentation preview 📚: https://sorna-ko--2166.org.readthedocs.build/ko/2166/ <!-- readthedocs-preview sorna-ko end --> Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2166
kyujin-cho
added a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com> Backported-from: main (24.09) Backported-to: 24.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR abstracts model service validation logic to another class so that it can be reused on consequent occurrences.
📚 Documentation preview 📚: https://sorna--2166.org.readthedocs.build/en/2166/
📚 Documentation preview 📚: https://sorna-ko--2166.org.readthedocs.build/ko/2166/
📚 Documentation preview 📚: https://sorna--2166.org.readthedocs.build/en/2166/
📚 Documentation preview 📚: https://sorna-ko--2166.org.readthedocs.build/ko/2166/