feat: update CLI to support controlling extra_mounts parameter
#2169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 22, 2024
Your org has enabled the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This was referenced May 22, 2024
github-actions
bot
added
comp:client
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
40a3300
to
d82ba12
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
c337357
to
e9a6aba
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
d82ba12
to
ace548f
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
e9a6aba
to
e4675f1
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
ace548f
to
4955e6b
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
e4675f1
to
4a9f6e3
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
4955e6b
to
80f6bfd
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
4a9f6e3
to
4173a1d
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
80f6bfd
to
d62f374
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
4173a1d
to
8a1f4cc
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
d62f374
to
3a077a1
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
8a1f4cc
to
b61b985
Compare
kyujin-cho
added
the
skip:changelog
Graphite App
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
3a077a1
to
dc4935e
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
b61b985
to
d02ae54
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
dc4935e
to
4c077bc
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
d02ae54
to
212e859
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
073d34a
to
2eb7e3c
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
212e859
to
b34062e
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
2eb7e3c
to
d62a667
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
b34062e
to
1be5fd3
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
d62a667
to
2f1f74b
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
1be5fd3
to
94e55b6
Compare
kyujin-cho
changed the title
extra_mounts flagextra_mounts parameter
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
2f1f74b
to
8a1ade8
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
94e55b6
to
effacf4
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
8a1ade8
to
91482ff
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
3 times, most recently
from
f199977
to
e0fbc89
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
8a57e67
to
76fa1ea
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
e0fbc89
to
49af846
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
622ab57
to
8cfe0f1
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
49af846
to
a4163b8
Compare
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
8cfe0f1
to
132bd3d
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
a4163b8
to
beac7ed
Compare
Merge activity
|
This PR updates CLI to be aware of newly added `extra_mounts` parameter when creating or updating model service.
kyujin-cho
force-pushed
the
topic/add-support-for-extra-mounts
branch
from
132bd3d
to
1b81caa
Compare
kyujin-cho
force-pushed
the
topic/update-cli
branch
from
beac7ed
to
be3a305
Compare
kyujin-cho
changed the base branch from
topic/add-support-for-extra-mounts
to
main
lablup-octodog
pushed a commit
that referenced
this pull request
May 28, 2024
This PR updates CLI to be aware of newly added parameter when creating or updating model service. Backported-from: main (24.09) Backported-to: 24.03 Backport-of: 2169
kyujin-cho
added a commit
that referenced
this pull request
May 28, 2024
Co-authored-by: Kyujin Cho <kyujin.cho@lablup.com> Backported-from: main (24.09) Backported-to: 24.03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates CLI to be aware of newly added
extra_mountsparameter when creating or updating model service.