is `environment` supposed to be reloaded on -SIGHUP?

[01micko]

See labwc/labwc-tweaks#3

labwc/labwc-tweaks#3 (comment)

[johanmalm]

Yes we ought to call session_environment_init() again on SIGHUP.
I think we'd have to reload the cursor images too.
Will try to focus on some popup/subsurfaces bugs and wlr_scene() first though.

[Consolatis]

f548fcd should be enough to reload the envrionment on SIGHUP. It will not change any internal cursor settings though so its only one part of the full solution. Every new application started after the SIGHUP will get the new environment. SIGHUP will also not delete anything from the environment because that would require tracking every key we set (and what the original value was before we set the new one). I am not sure it is worth doing that.

The internal cursor theme is set here:

labwc/src/cursor.c

Lines 794 to 802 in e1328c0

	void
	cursor_init(struct seat *seat)
	{
	const char *xcursor_theme = getenv("XCURSOR_THEME");
	const char *xcursor_size = getenv("XCURSOR_SIZE");
	uint32_t size = xcursor_size ? atoi(xcursor_size) : 24;
	seat->xcursor_manager = wlr_xcursor_manager_create(xcursor_theme, size);
	wlr_xcursor_manager_load(seat->xcursor_manager, 1);

I had a quick look at wlroots/include/wlr/types/wlr_xcursor_manager.h and there doesn't seem to be anything to change the theme after it has been loaded.

Will investigate a bit more but for now I'll send a PR to just update the environment on SIGHUP.

[01micko]

Thanks both but as @Consolatis revealed there is more to switching cursor than reloading the environment.