Skip to content

Conversation

afiune
Copy link
Contributor

@afiune afiune commented Nov 14, 2023

Summary

This change is fixing the following things:

  • Renames inputs from this module
    • prefix cloudformation inputs with cf_
    • remove - from subaccount (like the provider)
    • secrets start with lacework_access_
  • Remove external ID generation
  • make stack_name a variable
  • removes unnecessary provider dependencies

How did you test this change?

I have not. Waiting on @jefferyfry changes at https://github.com/lacework-alliances/aws-org-cf-lacework

Issue

N/A

@afiune afiune changed the title refactor: avoid generating External ID refactor: lots of fixes + cleanup Nov 14, 2023
Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Matt Cadorette and others added 3 commits November 13, 2023 19:22
Copy link

@ipcrm ipcrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are more changes behind this to fix, merging this as interim step.

@ipcrm ipcrm merged commit 07903b0 into main Nov 15, 2023
This was referenced Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants