Skip to content

fix: validation condition checks #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: validation condition checks #4

merged 1 commit into from
Nov 14, 2023

Conversation

ipcrm
Copy link

@ipcrm ipcrm commented Nov 14, 2023

Update validation logic on vars

afiune
afiune approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@afiune afiune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@afiune afiune merged commit 0fdea81 into afiune/fixeees Nov 14, 2023
@ipcrm ipcrm deleted the ipcrm-patch-2 branch November 14, 2023 20:04
ipcrm pushed a commit that referenced this pull request Nov 15, 2023
@afiune
refactor: lots of fixes + cleanup (#3)
07903b0 
* refactor: lots of fixes

* fix: validation condition checks (#4)

* fix: subaccount env var (#5)

* style: rename lacework_secret_key variable

---------

Signed-off-by: Salim Afiune Maya <afiune@lacework.net>
Co-authored-by: Matt Cadorette <matthew.cadorette@lacework.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@afiune afiune afiune approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ipcrm @afiune