Skip to content

update readme #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 8, 2023
Merged

update readme #12

merged 3 commits into from
Mar 8, 2023

Conversation

daphneherlambda
Copy link
Contributor

This PR updates the proyect readme to contain the docker container section

Copy link
Contributor

@Loco1982 Loco1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments, looks good!

README.md Outdated

In this repo the fuzzers have the following structure:

### if the fuzzer uses honggfuzz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### if the fuzzer uses honggfuzz
### Honggfuzz' fuzzer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
* The ***src*** folder contains the file main with the fuzzer
* The ***hfuzz_workspace*** folder contains a REPORT file with the report of the crashes the fuzzer found, this folder is updated each time the fuzzer finds a new crash and has the information about the crash along with the name of the input that triggered it. Also contains the input files that triggers the errors, the file names starts with SIGABRT

### if the fuzzer uses cargofuzz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### if the fuzzer uses cargofuzz
### Cargofuzz' fuzzer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
### if the fuzzer uses honggfuzz

* The ***src*** folder contains the file main with the fuzzer
* The ***hfuzz_workspace*** folder contains a REPORT file with the report of the crashes the fuzzer found, this folder is updated each time the fuzzer finds a new crash and has the information about the crash along with the name of the input that triggered it. Also contains the input files that triggers the errors, the file names starts with SIGABRT
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The ***hfuzz_workspace*** folder contains a REPORT file with the report of the crashes the fuzzer found, this folder is updated each time the fuzzer finds a new crash and has the information about the crash along with the name of the input that triggered it. Also contains the input files that triggers the errors, the file names starts with SIGABRT
* The ***hfuzz_workspace*** folder contains a REPORT file with the report of the crashes the fuzzer found, this folder is updated each time the fuzzer finds a new crash and has the information about the crash along with the name of the input that triggered it. Also contains the input files that trigger the errors, the file names start with SIGABRT

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
Comment on lines 29 to 31
* the ***fuzz_targets*** contains the files with the fuzzers


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* the ***fuzz_targets*** contains the files with the fuzzers
* the ***fuzz_targets*** contains the files with the fuzzers

It has one too many new lines

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
## User Guide

### 1. create the docker container
* Use the command `docker build -t ready-to-fuzz-image` inside this proyect to create a docker image named **ready-to-fuzz-image** from the dockerfile in the proyect.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Use the command `docker build -t ready-to-fuzz-image` inside this proyect to create a docker image named **ready-to-fuzz-image** from the dockerfile in the proyect.
* Use the command `docker build -t ready-to-fuzz-image` inside this project to create a docker image named **ready-to-fuzz-image** from the dockerfile in the project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should say 'project' not 'proyect'

README.md Outdated
## User Guide

### 1. create the docker container
* Use the command `docker build -t ready-to-fuzz-image` inside this proyect to create a docker image named **ready-to-fuzz-image** from the dockerfile in the proyect.
* run the command `docker run -it --rm --cap-add=SYS_PTRACE --security-opt seccomp=unconfined ready-to-fuzz-image bash` to run the container from the image previusly created.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* run the command `docker run -it --rm --cap-add=SYS_PTRACE --security-opt seccomp=unconfined ready-to-fuzz-image bash` to run the container from the image previusly created.
* run the command `docker run -it --rm --cap-add=SYS_PTRACE --security-opt seccomp=unconfined ready-to-fuzz-image bash` to run the container from the image previously created.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done!

README.md Outdated
* run the command `docker run -it --rm --cap-add=SYS_PTRACE --security-opt seccomp=unconfined ready-to-fuzz-image bash` to run the container from the image previusly created.

### 2. Run a fuzzer

Depending on the fuzzer use the following commands:

### If the Fuzzer Uses Honggfuzz

* to run it with total random data use:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* to run it with total random data use:
* to run it with totally random data use:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups typo, fixed!

Copy link
Contributor

@Loco1982 Loco1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a small issue left for me to approve this one

README.md Outdated
## User Guide

### 1. create the docker container
* Use the command `docker build -t ready-to-fuzz-image` inside this proyect to create a docker image named **ready-to-fuzz-image** from the dockerfile in the proyect.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should say 'project' not 'proyect'

Copy link
Contributor

@Loco1982 Loco1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Loco1982 Loco1982 merged commit 73907b2 into main Mar 8, 2023
@Loco1982 Loco1982 deleted the complement-proyect-readme branch March 8, 2023 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants