Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Construct OpenSearchVectorSearch using from_texts doesn't pass kwargs to opensearch client #2819

Closed
gregsharples opened this issue Apr 13, 2023 · 1 comment
Closed

Construct OpenSearchVectorSearch using from_texts doesn't pass kwargs to opensearch client #2819

gregsharples opened this issue Apr 13, 2023 · 1 comment

Comments

@gregsharples
Copy link

When using from_texts() method on the OpenSearchVectorSearch class it is not possible to pass kwargs to the Opensearch client (which does happen when using the standard __init__() constructor).

Fix is to add **kwargs to line 431 in opensearch_vector_search.py:

client = _get_opensearch_client(opensearch_url)
@naveentatikonda
Copy link
Contributor

@gregsharples Thank you for your feedback. Will add the fix to pass kwargs.

@naveentatikonda naveentatikonda mentioned this issue Apr 16, 2023
Merged
samching pushed a commit to samching/langchain that referenced this issue May 1, 2023
@naveentatikonda @samching
Pass kwargs to get OpenSearch client from_texts (langchain-ai#2993)
1a8ebf2 
### Description
Pass kwargs to get OpenSearch client from `from_texts` function

### Issues Resolved
langchain-ai#2819

Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregsharples @naveentatikonda