Pass kwargs to get OpenSearch client from_texts #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwchase17
reviewed
Apr 16, 2023
| # Remove the opensearch_url from kwargs to avoid passing | ||
| # the value twice for argument opensearch_url | ||
| kwargs.pop("opensearch_url") | ||
| client = _get_opensearch_client(opensearch_url, **kwargs) |
There was a problem hiding this comment.
what about all the other kwargs below?
There was a problem hiding this comment.
Sorry, didn't get your question?
There was a problem hiding this comment.
there are a lot of other arguments in "kwargs" that we use below. do we want to pop them as well? or are they relevant for the client
There was a problem hiding this comment.
Got it. I have updated the code to pop all those arguments before getting the opensearch client.
naveentatikonda
force-pushed
the
fix_github_issue_2819
branch
from
e3df0e4 to
47d650e
Compare
Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
naveentatikonda
force-pushed
the
fix_github_issue_2819
branch
from
47d650e to
231ae4e
Compare
samching
pushed a commit
to samching/langchain
that referenced
this pull request
May 1, 2023
### Description Pass kwargs to get OpenSearch client from `from_texts` function ### Issues Resolved langchain-ai#2819 Signed-off-by: Naveen Tatikonda <navtat@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pass kwargs to get OpenSearch client from
from_textsfunctionIssues Resolved
#2819