Skip to content

Conversation

amir9480
Copy link
Contributor

Hello.

I added PHPDoc with return type to model relationships.
It can help code editor provide autocomplete.

@jasonmccreary
Copy link
Collaborator

I think this should be good. However, you'll need to rebase and resolve the conflicts.

Also, can you have this honor the blueprint.generate_phpdocs config option as the buildClassPhpDoc does. That way these are only output when this option is true and not by default.

@amir9480
Copy link
Contributor Author

@jasonmccreary jasonmccreary merged commit 0c056fd into laravel-shift:master Apr 17, 2020
@amir9480 amir9480 deleted the add_model_relation_phpdoc branch April 21, 2020 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants