Skip to content

Conversation

msonowal
Copy link

Added support for unsigned integer column types with increments which was removed by the PR
#48

@jasonmccreary
Copy link
Collaborator

jasonmccreary commented Apr 15, 2020

I see the bug here. But this solution is not universal.

I think the correct logic is only when the name is id and the datatype is id. You are welcome to change this, or I can close and fix it later.

@msonowal
Copy link
Author

@jasonmccreary
At first I thought like that but seems like as there are conditions are added for more specific case so I thought it will be a global fix for only the id column

@jasonmccreary
Copy link
Collaborator

If you change it like I noted, do all the tests still pass? Where is the test for your use case?

@msonowal
Copy link
Author

Hi @jasonmccreary
I did tested in local it does pass everything, But I am not sure for writing the test specific for checking to column types as there no example present(I may be wrong), if you can enlighten me with some reference it will be very much helpful

@jasonmccreary
Copy link
Collaborator

You should be able to look at the MigrationGeneratorTest and add a fixture with your test case.

@ghostwriter
Copy link
Contributor

@msonowal sorry about the bug I introduced in #48, this #109 should fix it.

cc: @jasonmccreary

Added support for unsigned integer column types with increments which was removed by the PR
#48
@msonowal
Copy link
Author

cool @nathane ,

But I was already preparing the tests anyways thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants