Fix factory generation for morphs column type #135
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now if we use a morphs column type like:
We get a factory like this:

This PR will add those 2 fields (id and type) for morphs.
For a column definition like
morphs nullable
it will not generate factory fields for those 2 columns.An
isNullable()
helper method for the Column Model.Questions:
Should we add a factory definition for a nullable column?
In my opinion we shouldn't. If a column is nullable, the factory should not have a definition for that column, otherwise we don't have a way to set it to null. If we send a null value for a key, the factory will generate the value for that key.
Should we add support for
nullableMorphs
,nullableUuidMorphs
,nullableTimestamps
column definitions that are availabe on Laravel.So right now this works:
But this doesn't