Support model reference in validate statement to validate all columns #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this looks like a good start. What were your concerns or improvements? Much better commits this time too. 😉 |
|
I think it can be refatored using Laravel Collection to improve code readability. |
|
I see. Yeah. That's the entire codebase. 😅 |
|
I will try to refactor using Laravel Collection, but the upcoming week will be a little busy, so maybe I will not have time. But if you think this looks good and worth to merge, maybe you can refactor later then. |
|
No worries. I'll take a stab later in the week. Thanks again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this solution can be improved.
Closes #172