feat: add support for rememberToken() shorthand #229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the shorthand to `Blueprint::parse` - Update the `MigrationGenerator` for `rememberToken` - Update the `FactoryGenerator` for `remember_token` columns - Update the `ModelGenerator` to hide the attribute Closes #228
|
Dude, what is your Twitter handle so I can give you some praise. |
|
it's |
jasonmccreary
approved these changes
May 22, 2020
| * @dataProvider modelTreeDataProvider | ||
| */ | ||
| public function output_writes_migration_for_model_tree($definition, $path, $migration) | ||
| public function output_writes_factory_for_model_tree($definition, $path, $factory) |
There was a problem hiding this comment.
Thanks for scouting this.
|
Looks like one of the tests is failing due to the ordering of imports. This is my doing. But I can't edit it on the web. So I'm going to merge and fix the failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blueprint::parseMigrationGeneratorforrememberTokenFactoryGeneratorforremember_tokencolumnsModelGeneratorto hide the attributeCloses #228