Skip to content

Conversation

dmason30
Copy link
Contributor

Closes #236

Currently there is no way to override the default registered generators. This PR adds a swapGenerator method that was discussed in #236 with a matching test!

@jasonmccreary
Copy link
Collaborator

jasonmccreary commented May 24, 2020

I'm going to merge this, but leave it undocumented until you've let me know it works as expected in your Pest Tests add-on.

@jasonmccreary jasonmccreary merged commit 2a8d8e1 into laravel-shift:master May 24, 2020
@dmason30 dmason30 deleted the swap-generator branch May 25, 2020 15:04
@dmason30
Copy link
Contributor Author

@jasonmccreary I have finished making the add-on https://github.com/fidum/laravel-blueprint-pestphp-addon it works great using the swapGenerator.

I haven't created a release for it yet as it is currently using laravel-shift/blueprint:dev-master. I will wait patiently for your next release with the new function included.

I did essentially copy parts of your TestGenerator and tweak it to suit my needs I hope that is acceptable, I will watch for any bug fixes and port them over.

Out of interest, would you consider adding an add-ons section to the docs site, I understand if not.

@jasonmccreary
Copy link
Collaborator

Excellent. I will tag a Blueprint release later this evening.

Once we confirm it in action and see some use, I'm glad to add it to the documentation and promote it via Twitter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to override Test Generation?
2 participants