Skip to content

Conversation

bingtsingw
Copy link
Contributor

@bingtsingw bingtsingw commented Jul 25, 2020

What it does:

#164

  • when running php artisan vendor:publish --tag blueprint-stubs, it will copy default stubs to project's stubs/blueprint folder.
  • If project level stub exists, blueprint generator will use user stubs.

What it NOT does:

  • use laravel's own stubs which is located in project's stubs folder. I think this approach it's just fine :)

What left off:

  • rename/move stubs files
  • maybe rename some placeholder
    These are for elegant purpose, because once this feature rolled out, changing them will affect end user.

@bingtsingw
Copy link
Contributor Author

bingtsingw commented Jul 25, 2020

Update: Sorry, when fix conflicts, I merged it into this PR.


I have done renaming stub files, see https://github.com/bingtsingw/blueprint/commit/fd6352ddb8461b0885db5aa7f8fd31e09e8baecf, I can add it to this pr if you think they are OK.

@jasonmccreary
Copy link
Collaborator

What placeholders would you rename?

@bingtsingw
Copy link
Contributor Author

bingtsingw commented Jul 27, 2020

Hi, I already have everything done, just not sure if you have anything to check and add, so I left rename open for discussion, If you think everything is OK, just merge it. : )

There is one thing I'd like to point out:
Blueprint's form request stub is named form-request.stub, Lavavel's is named request.stub, I think blueprint's name is just fine, so I do not change it. What do you think?

@jasonmccreary
Copy link
Collaborator

Yes. Let's go ahead and rename the form request stub.

@bingtsingw
Copy link
Contributor Author

I renamed form-request.stub to request.stub and also renamed model.method-comment.stub to model.method.comment.stub for this naming convention.

@jasonmccreary
Copy link
Collaborator

Thanks. I'll merge this shortly, but wait to tag it until Thursday's live-stream. I'd like to test it locally and compare it to Laravel's publish command to see if there are any additional opportunities to align these more closely.

Until then, feel free to point to dev-master to try out these changes.

@jasonmccreary jasonmccreary merged commit a4311c6 into laravel-shift:master Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants