Skip to content

Conversation

devmsh
Copy link
Contributor

@devmsh devmsh commented Jul 25, 2020

Hi again!

I enjoyed refactoring the codebase so I can understand the current features before helping introduce a new one or pick a community requested enhancements.

Before going further with extra enhancements, I would like to take care of the tests suite, so I enabled the code coverage by adding the whitelisting section to the phpunit.xml config file.

The current code coverage reports below show that classes especially the commands and the top-level classes are not well-tested. I just want to double-check if you are interested to cover them?

Screen Shot 2020-07-25 at 16 26 29

In addition to that, I think the TraceCommand encapsulate too many concerns and the private method's logic need to be moved to another class to make the command lighter? if yes, what would you name the new class?

Screen Shot 2020-07-25 at 16 33 58

I asked about the TraceCommand specifically because it seems to me as the top candidate to be tested and refactored.

@devmsh
Copy link
Contributor Author

devmsh commented Jul 25, 2020

BTW, it's not a big concern, but I have no problem to refactor the entire test suite to use PEST if you interested!

@jasonmccreary
Copy link
Collaborator

Not interested in converting to Pest at this time.

As far as the commands, I agree they need to have more tests. Feel free to start with the primary ones like build and we'll work up to trace.

@jasonmccreary jasonmccreary merged commit 42824fb into laravel-shift:master Jul 25, 2020
@devmsh
Copy link
Contributor Author

devmsh commented Jul 25, 2020

Cool, will start with Build Command 👍

@devmsh devmsh deleted the test-refactoring branch July 29, 2020 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants