Add whitelist section to enable code coverage #314
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again!
I enjoyed refactoring the codebase so I can understand the current features before helping introduce a new one or pick a community requested enhancements.
Before going further with extra enhancements, I would like to take care of the
tests
suite, so I enabled the code coverage by adding the whitelisting section to thephpunit.xml
config file.The current code coverage reports below show that classes especially the commands and the top-level classes are not well-tested. I just want to double-check if you are interested to cover them?
In addition to that, I think the
TraceCommand
encapsulate too many concerns and the private method's logic need to be moved to another class to make the command lighter? if yes, what would you name the new class?I asked about the
TraceCommand
specifically because it seems to me as the top candidate to be tested and refactored.