Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to test the BuildCommand, I changed some code to make the
Builder
andBuildCommand
more testableBuilder
toBuildCommand
nested of Static method invocation to unit test the command. We can also provide e Builder facade and return the static method invocation if needed.file_exists
with$this->files->exists
to allow tests code to mock it.exit(1)
withreturn 1
so we can useassertExitCode(1)
and prevent the command from killing the test command.defaultDraftFile
is not related to the test code, and I can revert the change if you like the old style.Waiting for your feedback, and if everything goes ok, please select the next candidate to be tested.
Have a nice day 👍