lighter trace command to increase the reusability and testability #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for suggesting too many conflicting ideas. 😕
When I start thinking about the big picture and think how must we test the trace command itself, I realized that the command includes the full implementation in contrast to the build command which depends on
Buillder
class.The PR is not ready for merging yet, but I want to make sure that you are ok with the approach of separating the command from the logic itself. If yes, this will make it easier to call the
Tracer
in other command and test if it's called or not without calling a command from another command?I really enjoyed reading and refactoring the code, and I think I'm very close to start contributing new features and community requested enhancements.