Skip to content

fix-335 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix-335 #336

wants to merge 2 commits into from

Conversation

blackfyre
Copy link

This PR fixes issue #335

@blackfyre
Copy link
Author

The CI errors don't seem to be related to this PR.

There was 1 error:

1) Tests\Feature\Generators\ControllerGeneratorTest::output_writes_migration_for_controller_tree with data set #8 ('drafts/api-routes-example.yaml', 'app/Http/Controllers/Api/Cert...er.php', 'controllers/api-routes-example.php')
Mockery\Exception\NoMatchingExpectationException: No matching handler found for Mockery_8::put('app/Http/Controllers/Api/CertificateController.php',

@jasonmccreary
Copy link
Collaborator

Yeah, that was from some recent merges. Some kind of mismatch.

Given that and this one line change, I'm going to close this and make it myself while fixing the other issue as well as adding a test case for this date column.

@jasonmccreary jasonmccreary mentioned this pull request Aug 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blackfyre @jasonmccreary